Skip to content

feat: add stats/incr/nanewvariance - #6040

Merged
Planeshifter merged 8 commits into
stdlib-js:developfrom
Adithya-jh:feature/nanewvariance
Jul 16, 2026
Merged

Planeshifter merged 8 commits into
stdlib-js:developfrom
Adithya-jh:feature/nanewvariance

Conversation

@Adithya-jh

Copy link
Copy Markdown
Contributor

type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:

  • task: lint_filenames status: passed
  • task: lint_editorconfig status: passed
  • task: lint_markdown status: passed
  • task: lint_package_json status: passed
  • task: lint_repl_help status: passed
  • task: lint_javascript_src status: passed
  • task: lint_javascript_cli status: na
  • task: lint_javascript_examples status: passed
  • task: lint_javascript_tests status: passed
  • task: lint_javascript_benchmarks status: passed
  • task: lint_python status: na
  • task: lint_r status: na
  • task: lint_c_src status: na
  • task: lint_c_examples status: na
  • task: lint_c_benchmarks status: na
  • task: lint_c_tests_fixtures status: na
  • task: lint_shell status: na
  • task: lint_typescript_declarations status: passed
  • task: lint_typescript_tests status: passed
  • task: lint_license_headers status: passed ---

Resolves #5558 .

Description

What is the purpose of this pull request?

This pull request:

  • This pull request adds the nanewvariance module, which computes an incremental exponentially weighted variance while ignoring NaN values in the input data.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Mar 14, 2025
@Adithya-jh
Adithya-jh force-pushed the feature/nanewvariance branch from 1418f91 to 99177b3 Compare March 14, 2025 09:26
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@Adithya-jh
Adithya-jh force-pushed the feature/nanewvariance branch from 99177b3 to 370ba17 Compare March 14, 2025 09:30
@stdlib-bot

stdlib-bot commented Mar 14, 2025 •

Copy link
Copy Markdown
Contributor

Coverage Report

No coverage information available.

@Adithya-jh

Copy link
Copy Markdown
Contributor Author

Hi @kgryte
I have implemented the nanewvariance module. could you please review my code and tell me if there are any changes to be made.

@Planeshifter Planeshifter left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some late feedback in case there is appetite to move this PR along. Thanks for your work!

@Planeshifter Planeshifter added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Mar 10, 2026
Correct JSDoc and package descriptions to describe an exponentially
weighted variance, add a callable `declare function` signature and
remove the unused standalone type in the TypeScript declarations, and
use `@stdlib/math/base/assert/is-nan` with stdlib spacing conventions
in the example.
@Planeshifter
Planeshifter requested a review from a team July 15, 2026 05:35
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Jul 15, 2026
@Planeshifter

Copy link
Copy Markdown
Member

/stdlib merge

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jul 15, 2026
@Planeshifter

Copy link
Copy Markdown
Member

/stdlib update-copyright-years

@stdlib-bot

Copy link
Copy Markdown
Contributor

/stdlib update-copyright-years

@Planeshifter, the slash command failed to complete. Please check the workflow logs for details.

View workflow run

@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jul 15, 2026
stdlib-bot and others added 6 commits July 15, 2026 05:39
Aligns the function and module export with the incr-prefixed naming convention used across stats/incr packages and the package's own docs/types.
Replace string concatenation with format( '%s::accumulator', pkg ) and add the @stdlib/string/format require.
Correct the equation label/raw text and SVG image source, and rename README references to the incr-prefixed identifier.
Match the two-blank-line convention preceding the `// TESTS //`
separator used across sibling packages.

@Planeshifter Planeshifter left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me after clean-up. Thank you, @Adithya-jh!

@stdlib-bot

stdlib-bot commented Jul 16, 2026 •

Copy link
Copy Markdown
Contributor

PR Commit Message

feat: add `stats/incr/nanewvariance`

PR-URL: https://github.com/stdlib-js/stdlib/pull/6040
Closes: https://github.com/stdlib-js/stdlib/issues/5558

Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Co-authored-by: stdlib-bot <noreply@stdlib.io>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>

Please review the above commit message and make any necessary adjustments.

@kgryte kgryte changed the title feat(stats/incr): add nanewvariance module feat: add stats/incr/nanewvariance Jul 16, 2026
@kgryte

kgryte commented Jul 16, 2026

Copy link
Copy Markdown
Member

The titles of these PRs need to be cleaned up.

@kgryte kgryte added Feature Issue or pull request for adding a new feature. and removed Needs Changes Pull request which needs changes before being merged. Needs Review A pull request which needs code review. labels Jul 16, 2026
@Planeshifter
Planeshifter merged commit 4da47fe into stdlib-js:develop Jul 16, 2026
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature Issue or pull request for adding a new feature. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue. Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFC]: add stats/incr/nanewvariance

4 participants