Repository navigation
feat: add stats/incr/nancovariance - #5980
Conversation
|
Hello! Thank you for your contribution to stdlib. We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:
This acknowledgment confirms that you've read the guidelines, which include:
We can't review or accept contributions without this acknowledgment. Thank you for your understanding and cooperation. We look forward to reviewing your contribution! |
stdlib-bot
left a comment
There was a problem hiding this comment.
👋 Hi there! 👋
And thank you for opening your first pull request! We will review it shortly. 🏃 💨
Coverage Report
The above coverage report was generated for the changes in this PR. |
kgryte
left a comment
There was a problem hiding this comment.
Left an initial round of comments.
|
You are also missing the following files:
|
|
Sure i will look into all the changes. |
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown
status: na
- task: lint_package_json
status: passed
- task: lint_repl_help
status: passed
- task: lint_javascript_src
status: passed
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: passed
- task: lint_javascript_tests
status: passed
- task: lint_javascript_benchmarks
status: passed
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: na
- task: lint_c_examples
status: na
- task: lint_c_benchmarks
status: na
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: na
- task: lint_typescript_tests
status: na
- task: lint_license_headers
status: passed
---
fe8b96e to
e965bf2
Compare
|
Hi @kgryte |
Planeshifter
left a comment
There was a problem hiding this comment.
Some additional feedback.
Correct the JSDoc and TypeScript descriptions to describe a sample covariance ignoring NaN values, and align the TypeScript declarations and tests with the `stats/incr/covariance` conventions (lowercase `accumulator` type, relative import, and per-argument error checks).
|
/stdlib merge |
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown_pkg_readmes
status: na
- task: lint_markdown_docs
status: na
- task: lint_markdown
status: na
- task: lint_package_json
status: na
- task: lint_repl_help
status: passed
- task: lint_javascript_src
status: na
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: na
- task: lint_javascript_tests
status: na
- task: lint_javascript_benchmarks
status: na
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: na
- task: lint_c_examples
status: na
- task: lint_c_benchmarks
status: na
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: passed
- task: lint_typescript_tests
status: na
- task: lint_license_headers
status: passed
---
The `// returns` annotation must state exactly the returned value; move the explanatory parentheticals onto preceding comment lines so the REPL help lint passes.
Match the two-blank-line convention preceding the `// TESTS //` separator used across sibling packages.
Use the `// TESTS //` separator and drop the non-conventional `// MAIN //` heading and `// Additional tests...` comment, matching sibling packages such as stats/incr/covariance.
The related-packages section is autopopulated by tooling; empty the `See Also` block and related-links so entries are not authored by hand.
Use "compute a sample covariance incrementally, ignoring NaN values" across the package description, README, and module documentation, matching the phrasing used by sibling stats/incr/nan* packages.
Planeshifter
left a comment
There was a problem hiding this comment.
Looks alright to me after clean-up.
PR Commit MessagePlease review the above commit message and make any necessary adjustments. |
stats/incr/nancovariance
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:
Resolves #5554.
Description
This pull request:
Related Issues
This pull request:
stats/incr/nancovariance#5554Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers