Skip to content

feat: add stats/incr/nansumprod - #5780

Merged
Planeshifter merged 10 commits into
stdlib-js:developfrom
NirvedMishra:feature/5625
Jul 21, 2026
Merged

feat: add stats/incr/nansumprod#5780
Planeshifter merged 10 commits into
stdlib-js:developfrom
NirvedMishra:feature/5625

Conversation

@NirvedMishra

@NirvedMishra NirvedMishra commented Mar 4, 2025

Copy link
Copy Markdown
Contributor

This commits add a package nansumprod, which works like sumprod in which it calculates sum of product of two number iteratively ignoring NaN values

type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:

  • task: lint_filenames status: passed
  • task: lint_editorconfig status: passed
  • task: lint_markdown status: passed
  • task: lint_package_json status: passed
  • task: lint_repl_help status: passed
  • task: lint_javascript_src status: passed
  • task: lint_javascript_cli status: na
  • task: lint_javascript_examples status: passed
  • task: lint_javascript_tests status: passed
  • task: lint_javascript_benchmarks status: passed
  • task: lint_python status: na
  • task: lint_r status: na
  • task: lint_c_src status: na
  • task: lint_c_examples status: na
  • task: lint_c_benchmarks status: na
  • task: lint_c_tests_fixtures status: na
  • task: lint_shell status: na
  • task: lint_typescript_declarations status: passed
  • task: lint_typescript_tests status: passed
  • task: lint_license_headers status: passed ---

Resolves #5625 .

Description

What is the purpose of this pull request?

This pull request:

  • adds a package nansumprod, which works like sumprod in which it calculates sum of product of two number iteratively ignoring NaN values

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@NirvedMishra
feat(lib): added nansumprod package
c6a3eec 
This commits add a package nansumprod, which works like sumprod in which it calculates sum of product of two number iteratively ignoring NaN values

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: passed
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: passed
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: passed
  - task: lint_license_headers
    status: passed
---
@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Mar 4, 2025
@stdlib-bot

stdlib-bot commented Mar 4, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
stats/incr/nansumprod $\\color{green}135/135$
$\\color{green}+0.00\\%$ 		$\\color{green}8/8$
$\\color{green}+0.00\\%$ 		$\\color{green}2/2$
$\\color{green}+0.00\\%$ 		$\\color{green}135/135$
$\\color{green}+0.00\\%$

The above coverage report was generated for the changes in this PR.

@NirvedMishra

NirvedMishra commented Mar 5, 2025

Copy link
Copy Markdown
Contributor Author

@kgryte please, review this PR

@stdlib-bot stdlib-bot removed the First-time Contributor A pull request from a contributor who has never previously committed to the project repository. label Apr 1, 2025
@kgryte

kgryte commented Apr 2, 2025

Copy link
Copy Markdown
Member

/stdlib update-copyright-years

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Apr 2, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Apr 2, 2025
@kgryte kgryte changed the title feat(lib): added nansumprod package feat: add stats/incr/nansumprod Apr 2, 2025
@kgryte kgryte added the Feature Issue or pull request for adding a new feature. label Apr 2, 2025
@kgryte
style: fix indentation
5ecc812 
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte
kgryte self-requested a review April 2, 2025 05:08
Planeshifter
Planeshifter requested changes Mar 10, 2026
View reviewed changes

@Planeshifter Planeshifter left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left feedback. Thanks!

Comment thread lib/node_modules/@stdlib/stats/incr/nansumprod/package.json Resolved
Comment thread lib/node_modules/@stdlib/stats/incr/nansumprod/docs/types/index.d.ts Resolved
Comment thread lib/node_modules/@stdlib/stats/incr/nansumprod/examples/index.js Resolved
@Planeshifter Planeshifter added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Mar 10, 2026
This was referenced Jul 18, 2026
Closed
Closed
@Planeshifter
Planeshifter requested a review from a team July 20, 2026 20:26
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Jul 20, 2026
@Planeshifter

Planeshifter commented Jul 20, 2026

Copy link
Copy Markdown
Member

/stdlib merge

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jul 20, 2026
@Planeshifter

Planeshifter commented Jul 20, 2026

Copy link
Copy Markdown
Member

/stdlib update-copyright-years

@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jul 20, 2026
@stdlib-bot stdlib-bot added bot: In Progress Pull request is currently awaiting automation. and removed bot: In Progress Pull request is currently awaiting automation. labels Jul 20, 2026
Planeshifter
Planeshifter approved these changes Jul 21, 2026
View reviewed changes

@Planeshifter Planeshifter left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good to go. Thanks, @NirvedMishra!

@stdlib-bot stdlib-bot removed Needs Review A pull request which needs code review. Needs Changes Pull request which needs changes before being merged. labels Jul 21, 2026
@stdlib-bot

stdlib-bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

PR Commit Message

feat: add `stats/incr/nansumprod`

PR-URL: https://github.com/stdlib-js/stdlib/pull/5780
Closes: https://github.com/stdlib-js/stdlib/issues/5625

Co-authored-by: Athan Reines <kgryte@gmail.com>
Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Co-authored-by: stdlib-bot <noreply@stdlib.io>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Athan <kgryte@gmail.com>

Please review the above commit message and make any necessary adjustments.

@Planeshifter
Planeshifter merged commit 87efdeb into stdlib-js:develop Jul 21, 2026
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes
@kgryte kgryte Awaiting requested review from kgryte

Assignees

No one assigned

Labels

Feature Issue or pull request for adding a new feature. Good First PR A pull request resolving a Good First Issue. Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[RFC]: add stats/incr/nansumprod

4 participants

@NirvedMishra @stdlib-bot @kgryte @Planeshifter