Skip to content

feat: add C implementation for stats/base/dists/binomial/logpmf - #4417

Merged
Planeshifter merged 17 commits into
stdlib-js:developfrom
0PrashantYadav0:binomial/logpmf
Jul 24, 2026
Merged

feat: add C implementation for stats/base/dists/binomial/logpmf#4417
Planeshifter merged 17 commits into
stdlib-js:developfrom
0PrashantYadav0:binomial/logpmf

Conversation

@0PrashantYadav0

@0PrashantYadav0 0PrashantYadav0 commented Dec 31, 2024

Copy link
Copy Markdown
Member

Resolves #3468

Description

What is the purpose of this pull request?

This pull request:

  • adds C implementation for @stdlib/stats/base/dists/binomial/logpmf along with relevant tests, docs, examples and benchmarks.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

Neerajpathak07 and others added 5 commits December 27, 2024 23:49
@Neerajpathak07 @0PrashantYadav0
refactor: update stats/base/dnanmeanpn native addon from C++ to C
692afcb 
PR-URL: stdlib-js#4110
Reviewed-by: Athan Reines <kgryte@gmail.com>

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
---

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: passed
  - task: run_c_examples
    status: passed
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: passed
  - task: run_c_benchmarks
    status: passed
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: passed
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: passed
---
@0PrashantYadav0
Merge branch 'develop' of https://github.com/0PrashantYadav0/stdlib i…
e010038 
…nto develop

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: na
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
---

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: na
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---
@0PrashantYadav0
Merge branch 'develop' of https://github.com/0PrashantYadav0/stdlib i…
cc882e9 
…nto develop

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: na
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---
@0PrashantYadav0
Merge branch 'stdlib-js:develop' into develop
e9f48a5
@0PrashantYadav0
feat: add C implementation for binomail logpmf
cf34f9d 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: passed
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: passed
  - task: lint_c_examples
    status: passed
  - task: lint_c_benchmarks
    status: passed
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: na
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---
@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Dec 31, 2024
@stdlib-bot

stdlib-bot commented Dec 31, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Coverage Report

No coverage information available.

@0PrashantYadav0

0PrashantYadav0 commented Jan 6, 2025

Copy link
Copy Markdown
Member Author

/stdlib update-copyright-years

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jan 6, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jan 6, 2025
@0PrashantYadav0
feat: added new implementation and other minor updates
bfa5cbb 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: passed
  - task: lint_c_examples
    status: passed
  - task: lint_c_benchmarks
    status: passed
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: passed
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: passed
  - task: run_c_benchmarks
    status: passed
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: passed
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: passed
---
@Planeshifter Planeshifter added the bot: Update Copyright Years Pull request needing the copyright years of its files updated. label Feb 9, 2025
@stdlib-bot stdlib-bot added bot: In Progress Pull request is currently awaiting automation. and removed bot: Update Copyright Years Pull request needing the copyright years of its files updated. labels Feb 9, 2025
@Planeshifter Planeshifter removed the bot: In Progress Pull request is currently awaiting automation. label Feb 9, 2025
@0PrashantYadav0
Merge branch 'develop' into binomial/logpmf
53d6cff 
Signed-off-by: JoyBoy <144602492+0PrashantYadav0@users.noreply.github.com>
@0PrashantYadav0
fix: changes in benchmarks
d53556e 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: passed
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---
@0PrashantYadav0

0PrashantYadav0 commented Mar 11, 2025

Copy link
Copy Markdown
Member Author

/stdlib merge

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Mar 11, 2025
@stdlib-bot stdlib-bot added Good First PR A pull request resolving a Good First Issue. and removed bot: In Progress Pull request is currently awaiting automation. labels Mar 11, 2025
@Planeshifter

Planeshifter commented Jun 23, 2025

Copy link
Copy Markdown
Member

/stdlib merge

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jun 23, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jun 23, 2025
@Planeshifter
fix: improve parameter validation and style in binomial/logpmf
3bd23e1 
- Fix integer comparisons in edge cases (x == 0 instead of x == 0.0)
- Improve parameter validation logic for cleaner code flow
- Fix JSDoc example to use integer (3 instead of 3.0)
- Maintain correct int32_t types for discrete parameters x and n

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: na
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: na
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---
@Planeshifter
fix: improve binomial logpmf documentation and test structure
7daa1e7 
- Fix documentation descriptions to use consistent "Evaluates" terminology
- Remove unused includes in C source files
- Update test cases to use integer literals for consistency
- Clean up parameter validation and documentation

Note: C implementation currently has functional issues returning NaN,
but structure and documentation are improved. Keeping int32_t types
as requested for x and n parameters.

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: na
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
---

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
---

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
---
Planeshifter
Planeshifter reviewed Jun 23, 2025
View reviewed changes
Comment thread lib/node_modules/@stdlib/stats/base/dists/binomial/logpmf/README.md
@Lokeshranjan8

Lokeshranjan8 commented Apr 14, 2026

Copy link
Copy Markdown
Contributor

Hi @0PrashantYadav0 , are you still working on this PR? If not, I can help.

@0PrashantYadav0

0PrashantYadav0 commented Apr 14, 2026

Copy link
Copy Markdown
Member Author

@Lokeshranjan8 No, you can work on this now.

@0PrashantYadav0
0PrashantYadav0 requested a review from a team July 3, 2026 08:58
@0PrashantYadav0

0PrashantYadav0 commented Jul 3, 2026

Copy link
Copy Markdown
Member Author

/stdlib update-copyright-year

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jul 3, 2026
@stdlib-bot

stdlib-bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

/stdlib update-copyright-year

@0PrashantYadav0, slash command not recognized. Please use /stdlib help to view available commands.

@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jul 3, 2026
@0PrashantYadav0

0PrashantYadav0 commented Jul 3, 2026

Copy link
Copy Markdown
Member Author

/stdlib help

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jul 3, 2026
@stdlib-bot

stdlib-bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

@0PrashantYadav0, available slash commands include:

  • /stdlib check-files - Check for required files.
  • /stdlib make-commands - Print make commands for package changed in PR.
  • /stdlib update-copyright-years - Update copyright header years.
  • /stdlib lint-autofix - Auto-fix lint errors.
  • /stdlib merge - Merge changes from develop branch into this PR.
  • /stdlib rebase - Rebase this PR on top of develop branch.
  • /stdlib todo - Create a new todo issue.

@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jul 3, 2026
@0PrashantYadav0

0PrashantYadav0 commented Jul 3, 2026

Copy link
Copy Markdown
Member Author

/stdlib update-copyright-years

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jul 3, 2026
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jul 3, 2026
@Planeshifter Planeshifter mentioned this pull request Jul 24, 2026
Closed
Planeshifter
Planeshifter reviewed Jul 24, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/stats/base/dists/binomial/logpmf/src/addon.c Outdated
@Planeshifter
fix: change x parameter type from int32_t to double for consistency w…
4060ff1 
…ith pmf sibling

- Refactor C signature to (double x, int32_t n, double p) matching binomial/pmf
- Add is_nan(x) and is_nonnegative_integer(x) checks matching JS implementation
- Update NAPI macro from IID_D to DID_D
- Remove unused pinf dependency from manifest.json
- Use format() for benchmark description string
- Standardize test assertion messages to 'returns expected value'
Planeshifter
Planeshifter reviewed Jul 24, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/stats/base/dists/binomial/logpmf/src/addon.c Outdated
@Planeshifter
chore: remove unused directive
43aa658 
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Planeshifter
Planeshifter approved these changes Jul 24, 2026
View reviewed changes

@Planeshifter Planeshifter left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get it in. Thanks, @0PrashantYadav0!

@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Jul 24, 2026
@stdlib-bot

stdlib-bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

PR Commit Message

feat: add C implementation for `stats/base/dists/binomial/logpmf`

PR-URL: https://github.com/stdlib-js/stdlib/pull/4417
Closes: https://github.com/stdlib-js/stdlib/issues/3468

Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Co-authored-by: stdlib-bot <noreply@stdlib.io>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: JoyBoy <144602492+0PrashantYadav0@users.noreply.github.com>
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>

Please review the above commit message and make any necessary adjustments.

@Planeshifter
Planeshifter merged commit 34af926 into stdlib-js:develop Jul 24, 2026
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

Assignees

No one assigned

Labels

Good First PR A pull request resolving a Good First Issue. Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[RFC]: Add C implementation for @stdlib/stats/base/dists/binomial/logpmf

5 participants

@0PrashantYadav0 @stdlib-bot @Planeshifter @Lokeshranjan8 @Neerajpathak07