feat: add C implementation for `stats/base/dists/binomial/quantile` by 0PrashantYadav0 · Pull Request #4415 · stdlib-js/stdlib

0PrashantYadav0 · 2024-12-31T15:19:12Z

Resolves #3474

Description

What is the purpose of this pull request?

This pull request:

adds C implementation for @stdlib/stats/base/dists/binomial/quantile along with relevant tests, docs, examples and benchmarks.

Related Issues

Does this pull request have any related issues?

This pull request:

resolves [RFC]: Add C implementation for @stdlib/stats/base/dists/binomial/quantile #3474

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

Read, understood, and followed the contributing guidelines.

@stdlib-js/reviewers

PR-URL: stdlib-js#4110 Reviewed-by: Athan Reines <kgryte@gmail.com> --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: passed - task: run_c_examples status: passed - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: passed - task: run_c_benchmarks status: passed - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: passed - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: passed ---

…nto develop --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: na - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: na - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: na --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: na - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: na - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: na ---

…nto develop --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: na - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: na - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: na ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: passed - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: passed - task: lint_c_examples status: passed - task: lint_c_benchmarks status: passed - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: na - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: na - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: na ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: passed - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: na - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: na ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: passed - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: passed - task: lint_c_examples status: passed - task: lint_c_benchmarks status: passed - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: na - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: na - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: na ---

stdlib-bot · 2024-12-31T15:21:57Z

Coverage Report

Package	Statements	Branches	Functions	Lines
stats/base/dists/binomial/quantile	$\\color{red}522/524$ $\\color{green}+0.00\\%$	$\\color{red}61/62$ $\\color{green}+0.00\\%$	$\\color{green}6/6$ $\\color{green}+0.00\\%$	$\\color{red}522/524$ $\\color{green}+0.00\\%$

The above coverage report was generated for the changes in this PR.

0PrashantYadav0 · 2025-01-06T14:26:05Z

/stdlib update-copyright-years

0PrashantYadav0 · 2025-01-06T14:47:34Z

@Planeshifter @kgryte this one is also similar to #4414 (same doubt)

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: passed - task: lint_c_examples status: passed - task: lint_c_benchmarks status: passed - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: passed - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: passed - task: run_c_benchmarks status: passed - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: passed - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: passed ---

…0/stdlib into binomial/quantile --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: passed - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: passed - task: run_c_benchmarks status: passed - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: na - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: na ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: passed - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: passed - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: passed - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: na ---

Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>

- Fix TypeScript parameter documentation (p → r, correct return value) - Add missing edge cases to C implementation (p=0, p=1, n=0) - Add TODO comment highlighting algorithm inefficiency NOTE: The C implementation uses a naive brute-force algorithm that is mathematically different from the sophisticated Cornish-Fisher expansion used in the JavaScript version. This needs a complete rewrite for production use.

…ithm - Replace naive brute-force algorithm with sophisticated Cornish-Fisher expansion - Use binomial CDF for efficient search instead of computing PMF in loop - Add required dependencies: sqrt, round, erfcinv, sqrt-two constant, binomial/cdf - Implement same algorithm as JavaScript version for consistency - Dramatically improve performance and numerical stability for large n This fixes the critical algorithmic flaw where the C implementation was completely different from the JavaScript version and would fail for large n.

0PrashantYadav0 · 2025-06-25T07:51:23Z

@Planeshifter I think we have a problem here. This package depends on the C implementation of binomial/cdf, which in turn depends on math/base/special/betainc, and that depends on math/base/special/kernel-betainc, which itself depends on many other packages.

@kgryte Any thought on how to proceed.

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown_pkg_readmes status: passed - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: missing_dependencies - task: lint_c_examples status: missing_dependencies - task: lint_c_benchmarks status: missing_dependencies - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

Neerajpathak07 · 2026-07-23T05:57:00Z

/stdlib update-copyright-years

0PrashantYadav0 · 2026-07-23T09:14:45Z

I will make changes and open this pr soon.

Neerajpathak07 · 2026-07-23T09:55:55Z

@0PrashantYadav0 The changes have been implemented as per dc2b81e.

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

Planeshifter · 2026-07-24T04:09:35Z

/stdlib merge

…ss review feedback - Add static to search_left() and search_right() to prevent symbol collisions - Fix search_right() JSDoc: 'to the left' -> 'to the right' - Remove trailing semicolon after NAPI macro - Standardize test assertion messages to 'returns expected value'

Planeshifter

Thanks @0PrashantYadav0 and @Neerajpathak07!

Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>

stdlib-bot · 2026-07-24T04:25:27Z

PR Commit Message

feat: add C implementation for `stats/base/dists/binomial/quantile`

PR-URL: https://github.com/stdlib-js/stdlib/pull/4415
Closes: https://github.com/stdlib-js/stdlib/issues/3474

Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Co-authored-by: stdlib-bot <noreply@stdlib.io>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>

Please review the above commit message and make any necessary adjustments.

Neerajpathak07 and others added 8 commits December 27, 2024 23:49

Merge branch 'stdlib-js:develop' into develop

e9f48a5

stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Dec 31, 2024

stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jan 6, 2025

chore: update copyright years

e9a321a

stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jan 6, 2025

0PrashantYadav0 added 3 commits January 6, 2025 20:18

Planeshifter added the bot: Update Copyright Years Pull request needing the copyright years of its files updated. label Feb 9, 2025

stdlib-bot added bot: In Progress Pull request is currently awaiting automation. and removed bot: Update Copyright Years Pull request needing the copyright years of its files updated. labels Feb 9, 2025

Planeshifter removed the bot: In Progress Pull request is currently awaiting automation. label Feb 9, 2025

Merge branch 'develop' into binomial/quantile

cca55a0

Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>

stdlib-bot added the Good First PR A pull request resolving a Good First Issue. label Jun 23, 2025

Planeshifter added 2 commits June 22, 2025 21:15

Merge branch 'develop' into binomial/quantile

6499361

0PrashantYadav0 requested a review from a team July 3, 2026 06:48

stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jul 23, 2026

chore: update copyright years

a08c3bb

stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jul 23, 2026

Neerajpathak07 marked this pull request as ready for review July 23, 2026 06:01

stdlib-bot added the Needs Review A pull request which needs code review. label Jul 23, 2026

Neerajpathak07 force-pushed the binomial/quantile branch from 67db909 to 9893bd9 Compare July 23, 2026 14:02

Planeshifter mentioned this pull request Jul 24, 2026

Land stats/base/dists/binomial C implementation PRs stdlib-js/metr-issue-tracker#1078

Closed

Planeshifter reviewed Jul 24, 2026

View reviewed changes

Comment thread lib/node_modules/@stdlib/stats/base/dists/binomial/quantile/benchmark/c/benchmark.c Outdated

stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jul 24, 2026

Merge remote-tracking branch 'upstream/develop' into binomial/quantile

561fae6

stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jul 24, 2026

Planeshifter force-pushed the binomial/quantile branch from 2e044f3 to 7d2aee1 Compare July 24, 2026 04:20

Planeshifter force-pushed the binomial/quantile branch from 7d2aee1 to b25736a Compare July 24, 2026 04:22

Planeshifter previously approved these changes Jul 24, 2026

View reviewed changes

style: add missing space

c0eb547

Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>

Planeshifter dismissed their stale review via c0eb547 July 24, 2026 04:24

Planeshifter approved these changes Jul 24, 2026

View reviewed changes

Planeshifter added the Ready To Merge label Jul 24, 2026

stdlib-bot removed the Needs Review A pull request which needs code review. label Jul 24, 2026

Planeshifter merged commit fd3be1e into stdlib-js:develop Jul 24, 2026
31 checks passed

stdlib-bot removed the Ready To Merge label Jul 24, 2026

Navigation Menu

Repository navigation

feat: add C implementation for `stats/base/dists/binomial/quantile` - #4415

feat: add C implementation for `stats/base/dists/binomial/quantile`#4415
Planeshifter merged 24 commits into
stdlib-js:developfrom
0PrashantYadav0:binomial/quantile

0PrashantYadav0 commented Dec 31, 2024

Uh oh!

stdlib-bot commented Dec 31, 2024 •

edited

Loading

Uh oh!

0PrashantYadav0 commented Jan 6, 2025

Uh oh!

0PrashantYadav0 commented Jan 6, 2025

Uh oh!

0PrashantYadav0 commented Jun 25, 2025 •

edited

Loading

Uh oh!

Neerajpathak07 commented Jul 23, 2026

Uh oh!

0PrashantYadav0 commented Jul 23, 2026

Uh oh!

Neerajpathak07 commented Jul 23, 2026

Uh oh!

Uh oh!

Planeshifter commented Jul 24, 2026

Uh oh!

Planeshifter left a comment

Uh oh!

stdlib-bot commented Jul 24, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

0PrashantYadav0 commented Dec 31, 2024

Description

Related Issues

Questions

Other

Checklist

Uh oh!

stdlib-bot commented Dec 31, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report

Uh oh!

0PrashantYadav0 commented Jan 6, 2025

Uh oh!

0PrashantYadav0 commented Jan 6, 2025

Uh oh!

0PrashantYadav0 commented Jun 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Neerajpathak07 commented Jul 23, 2026

Uh oh!

0PrashantYadav0 commented Jul 23, 2026

Uh oh!

Neerajpathak07 commented Jul 23, 2026

Uh oh!

Uh oh!

Planeshifter commented Jul 24, 2026

Uh oh!

Planeshifter left a comment

Choose a reason for hiding this comment

Uh oh!

stdlib-bot commented Jul 24, 2026

PR Commit Message

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

stdlib-bot commented Dec 31, 2024 •

edited

Loading

0PrashantYadav0 commented Jun 25, 2025 •

edited

Loading