feat: add `math/base/special/expf` by vivekmaurya001 · Pull Request #3318 · stdlib-js/stdlib

vivekmaurya001 · 2024-12-03T13:47:01Z

Progresses #649

Description

adds math/base/special/expf, which would be the single-precision equivalent for math/base/special/exp.

This pull request:

Progresses: [RFC]: Add C implementations to base special math functions (tracking issue) #649

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

Read, understood, and followed the contributing guidelines

@stdlib-js/reviewers

…https://github.com/vivekmaurya001/stdlib into Add-C-implementations-to-base-special-math-functions

stdlib-bot · 2024-12-03T13:47:38Z

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

Please read our contributing guidelines.
Update your pull request description to include this checked box:

- [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

The developer's certificate of origin
Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

stdlib-bot

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

gunjjoshi · 2024-12-03T14:42:04Z

@vivekmaurya001 Thanks for working on this, CI tests must pass in order to move ahead with this PR.

…pecial-math-functions

…https://github.com/vivekmaurya001/stdlib into Add-C-implementations-to-base-special-math-functions

…pecial-math-functions

…https://github.com/vivekmaurya001/stdlib into Add-C-implementations-to-base-special-math-functions

stdlib-bot · 2024-12-04T18:58:47Z

Coverage Report

Package	Statements	Branches	Functions	Lines
math/base/special/expf	$\\color{red}494/496$ $\\color{green}+0.06\\%$	$\\color{red}23/24$ $\\color{green}+0.00\\%$	$\\color{green}4/4$ $\\color{green}+0.00\\%$	$\\color{red}494/496$ $\\color{green}+0.06\\%$

The above coverage report was generated for the changes in this PR.

vivekmaurya001 · 2024-12-04T19:12:27Z

done changes , waiting for your inputs in this @gunjjoshi !

…pecial-math-functions

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown_pkg_readmes status: passed - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: passed - task: lint_repl_help status: passed - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: passed - task: lint_c_examples status: passed - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: passed - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: passed - task: lint_license_headers status: passed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: passed - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

anandkaranubc

I think this should be ready to merge.

cc: @kgryte

Co-authored-by: Karan Anand <119553199+anandkaranubc@users.noreply.github.com> Signed-off-by: Karan Anand <119553199+anandkaranubc@users.noreply.github.com>

Signed-off-by: Athan <kgryte@gmail.com>

kgryte

LGTM after clean-up and proper attribution.

vivekmaurya001 added 3 commits December 3, 2024 17:14

added expf implementation

b188fdd

test file updated

b9099eb

Merge branch 'Add-C-implementations-to-base-special-math-functions' of …

6a1c503

…https://github.com/vivekmaurya001/stdlib into Add-C-implementations-to-base-special-math-functions

stdlib-bot added the Math Issue or pull request specific to math functionality. label Dec 3, 2024

stdlib-bot reviewed Dec 3, 2024

View reviewed changes

gunjjoshi changed the title ~~feat: add math/base/special/expf~~ feat: add math/base/special/expf Dec 3, 2024

vivekmaurya001 and others added 3 commits December 3, 2024 20:33

updated main.js

3bfc14c

Merge branch 'stdlib-js:develop' into Add-C-implementations-to-base-s…

3f6abb2

…pecial-math-functions

Merge branch 'Add-C-implementations-to-base-special-math-functions' of …

a62792a

…https://github.com/vivekmaurya001/stdlib into Add-C-implementations-to-base-special-math-functions

kgryte added the Needs Changes Pull request which needs changes before being merged. label Dec 3, 2024

vivekmaurya001 and others added 9 commits December 4, 2024 15:17

added fixtures

7ece9c1

Merge branch 'stdlib-js:develop' into Add-C-implementations-to-base-s…

8a6128e

…pecial-math-functions

Merge branch 'Add-C-implementations-to-base-special-math-functions' of …

dd9cf61

…https://github.com/vivekmaurya001/stdlib into Add-C-implementations-to-base-special-math-functions

scaled tolerance value

9bcb506

changed test.native file

08ebbbe

changed the computation methods

3c9f6ff

updated main.c

9b3a5c1

updated main.c

9bded14

updated main.c values

8415ab6

kgryte reviewed Dec 4, 2024

View reviewed changes

Comment thread lib/node_modules/@stdlib/math/base/special/expf/src/main.c

vivekmaurya001 and others added 6 commits December 5, 2024 09:41

Resolved coeffiecients in evalpoly

a179c6d

Merge branch 'stdlib-js:develop' into Add-C-implementations-to-base-s…

2ebc5a3

…pecial-math-functions

Merge branch 'stdlib-js:develop' into Add-C-implementations-to-base-s…

bb9e04e

…pecial-math-functions

feat(math): add math/base/special/expf

df0e6c7

feat(math): add math/base/special/expf

cc6918c

Merge branch 'stdlib-js:develop' into Add-C-implementations-to-base-s…

a6a1f37

…pecial-math-functions

anandkaranubc requested a review from a team August 4, 2026 16:17

stdlib-bot added the Needs Review A pull request which needs code review. label Aug 4, 2026

anandkaranubc mentioned this pull request Aug 4, 2026

Clean-up math/base/special/expf stdlib-js/metr-issue-tracker#1111

Closed

anandkaranubc self-requested a review August 4, 2026 17:18

anandkaranubc added 6 commits August 4, 2026 19:43

anandkaranubc previously approved these changes Aug 5, 2026

View reviewed changes

anandkaranubc reviewed Aug 5, 2026

View reviewed changes

Comment thread lib/node_modules/@stdlib/math/base/special/powf/lib/polyval_l.js Outdated

anandkaranubc reviewed Aug 5, 2026

View reviewed changes

Comment thread lib/node_modules/@stdlib/math/base/special/powf/lib/polyval_p.js Outdated

anandkaranubc reviewed Aug 5, 2026

View reviewed changes

Comment thread lib/node_modules/@stdlib/math/base/special/powf/lib/polyval_w.js Outdated

Apply suggestions from code review

a4d6304

Co-authored-by: Karan Anand <119553199+anandkaranubc@users.noreply.github.com> Signed-off-by: Karan Anand <119553199+anandkaranubc@users.noreply.github.com>

anandkaranubc dismissed their stale review via a4d6304 August 5, 2026 05:28

anandkaranubc previously approved these changes Aug 5, 2026

View reviewed changes

anandkaranubc added METR Pull request associated with the METR project. and removed Needs Changes Pull request which needs changes before being merged. labels Aug 5, 2026

anandkaranubc mentioned this pull request Aug 5, 2026

feat: add math/base/special/sinhf #13611

Merged

3 of 7 tasks

kgryte reviewed Aug 5, 2026

View reviewed changes

Comment thread lib/node_modules/@stdlib/math/base/special/expf/lib/expmultif.js Outdated

docs: fix license

a6e54e7

Signed-off-by: Athan <kgryte@gmail.com>

kgryte dismissed anandkaranubc’s stale review via a6e54e7 August 5, 2026 07:57

kgryte added 3 commits August 5, 2026 00:58

docs: fix license

ec3f3c8

Signed-off-by: Athan <kgryte@gmail.com>

docs: fix license

f3ff3f2

Signed-off-by: Athan <kgryte@gmail.com>

docs: fix license

8937f53

Signed-off-by: Athan <kgryte@gmail.com>

kgryte approved these changes Aug 5, 2026

View reviewed changes

kgryte removed the Needs Review A pull request which needs code review. label Aug 5, 2026

kgryte merged commit f6bf21b into stdlib-js:develop Aug 5, 2026
14 checks passed

Planeshifter mentioned this pull request Aug 5, 2026

docs: add Git note #13952

Merged

4 of 7 tasks

Navigation Menu

Repository navigation

feat: add `math/base/special/expf` - #3318

feat: add `math/base/special/expf`#3318
kgryte merged 80 commits into
stdlib-js:developfrom
vivekmaurya001:Add-C-implementations-to-base-special-math-functions

vivekmaurya001 commented Dec 3, 2024 •

edited by gunjjoshi

Loading

Uh oh!

stdlib-bot commented Dec 3, 2024

Uh oh!

stdlib-bot left a comment

Uh oh!

gunjjoshi commented Dec 3, 2024

Uh oh!

stdlib-bot commented Dec 4, 2024 •

edited

Loading

Uh oh!

vivekmaurya001 commented Dec 4, 2024

Uh oh!

Uh oh!

anandkaranubc left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kgryte left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

vivekmaurya001 commented Dec 3, 2024 • edited by gunjjoshi Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Questions

Other

Checklist

Uh oh!

stdlib-bot commented Dec 3, 2024

Uh oh!

stdlib-bot left a comment

Choose a reason for hiding this comment

Uh oh!

gunjjoshi commented Dec 3, 2024

Uh oh!

stdlib-bot commented Dec 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report

Uh oh!

vivekmaurya001 commented Dec 4, 2024

Uh oh!

Uh oh!

anandkaranubc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kgryte left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

vivekmaurya001 commented Dec 3, 2024 •

edited by gunjjoshi

Loading

stdlib-bot commented Dec 4, 2024 •

edited

Loading