Skip to content

feat: add blas/ext/base/ndarray/dapxsumkbn - #16434

Open
AtharvaPatange wants to merge 1 commit into
stdlib-js:developfrom
AtharvaPatange:feat/blas-ndarray-dapxsumkbn
Open

AtharvaPatange wants to merge 1 commit into
stdlib-js:developfrom
AtharvaPatange:feat/blas-ndarray-dapxsumkbn

Conversation

@AtharvaPatange

Copy link
Copy Markdown
Contributor

Resolves a part of #14404

Description

What is the purpose of this pull request?

This pull request:

  • Implements the ndarray API wrapper for @stdlib/blas/ext/base/dapxsumkbn (adds a scalar constant to each element in a one-dimensional double-precision floating-point ndarray and computes the sum using an improved Kahan–Babuška algorithm).
  • Ensures consistency with canonical conventions across existing @stdlib/blas/ext/base/ndarray packages (such as dsumkbn and dapx).
  • Includes comprehensive unit tests, benchmarks, TypeScript typings (index.d.ts and test.ts), REPL documentation, and examples.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

I used an AI assistant to audit remaining implementations for #14404, research reference patterns from existing ndarray packages (dapx and dsumkbn), and help scaffold tests (including KBN catastrophic cancellation and zero-sign preservation tests), benchmarks, and TypeScript definitions. All changes were manually verified and tested against the @stdlib/blas/ext/base/dapxsumkbn base implementation.


@stdlib-js/reviewers

@AtharvaPatange
AtharvaPatange requested a review from a team November 1, 2026 10:29
@stdlib-bot stdlib-bot added BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Needs Review A pull request which needs code review. labels Nov 1, 2026
@stdlib-bot

stdlib-bot commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
blas/ext/base/ndarray/dapxsumkbn $\\color{green}119/119$
$\\color{green}+0.00\\%$
$\\color{green}3/3$
$\\color{green}+0.00\\%$
$\\color{green}1/1$
$\\color{green}+0.00\\%$
$\\color{green}119/119$
$\\color{green}+0.00\\%$

The above coverage report was generated for the changes in this PR.

@AtharvaPatange
AtharvaPatange force-pushed the feat/blas-ndarray-dapxsumkbn branch from 3c7dc4c to b1e3366 Compare November 1, 2026 10:50

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Needs Review A pull request which needs code review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants