Skip to content

fix: return correct MGF value when t is zero in stats/base/dists/cosine/mgf #16425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
harsh-thakkar7 wants to merge 1 commit into
base: develop
Choose a base branch
from
+16 −0
Open

fix: return correct MGF value when t is zero in stats/base/dists/cosine/mgf #16425

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lib/node_modules/@stdlib/stats/base/dists/cosine/mgf/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,9 @@ var y = mgf( 2.0, 0.0, 3.0 );
y = mgf( 0.5, 0.0, 1.0 );
// returns ~1.016

y = mgf( 0.0, 2.0, 5.0 );
// returns 1.0

y = mgf( -1.0, 4.0, 2.0 );
// returns ~0.024
```
Expand Down
3 changes: 3 additions & 0 deletions lib/node_modules/@stdlib/stats/base/dists/cosine/mgf/lib/factory.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,9 @@ function factory( mu, s ) {
return NaN;
}
st = s * t;
if ( st === 0.0 ) {
return 1.0;
}
out = PI_SQUARED * sinh( st );
out /= st * ( PI_SQUARED + ( st*st ) );
out *= exp( mu * t );
Expand Down
7 changes: 7 additions & 0 deletions lib/node_modules/@stdlib/stats/base/dists/cosine/mgf/lib/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,10 @@ var PI_SQUARED = require( '@stdlib/constants/float64/pi-squared' );
* // returns ~1.016
*
* @example
* var y = mgf( 0.0, 2.0, 5.0 );
* // returns 1.0
*
* @example
* var y = mgf( 1.2, 0.0, 1.0 );
* // returns ~1.098
*
Expand Down Expand Up @@ -72,6 +76,9 @@ function mgf( t, mu, s ) {
return NaN;
}
st = s * t;
if ( st === 0.0 ) {
return 1.0;
}
out = PI_SQUARED * sinh( st );
out /= st * ( PI_SQUARED + ( st*st ) );
out *= exp( mu * t );
Expand Down
3 changes: 3 additions & 0 deletions lib/node_modules/@stdlib/stats/base/dists/cosine/mgf/src/main.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,9 @@ double stdlib_base_dists_cosine_mgf( const double t, const double mu, const doub
) {
return 0.0/0.0; // NaN
}
if ( t == 0.0 ) {
return 1.0;
}
const double st = s*t;
double out = STDLIB_CONSTANT_FLOAT64_PI_SQUARED * stdlib_base_sinh( st );
out /= st * ( STDLIB_CONSTANT_FLOAT64_PI_SQUARED + ( st*st ) );
Expand Down
Loading