Repository navigation
fix: add missing bench task config to complex/float32/base/assert/is_equal - #16423
Open
harsh-thakkar7 wants to merge 1 commit into
Open
harsh-thakkar7 wants to merge 1 commit into
harsh-thakkar7 wants to merge 1 commit into
Conversation
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #11756.
Description
This pull request:
benchmarktask configuration to themanifest.jsonof@stdlib/complex/float32/base/assert/is-equal, mirroring the existingbuildandexamplesconfigurations.Without it, C benchmark builds of dependent packages (e.g.,
blas/base/cgemv) fail to compile because no generated build emitsis_equal.hfor the benchmark task.Related Issues
This pull request has the following related issues:
@stdlib/complex/float32/base/assert/is-equalmissing benchmark configuration inmanifest.json#11756complex/float64/base/assert/is_equal#10235 (the same fix for thefloat64sibling package)Reference Packages
This pull request followed these packages:
complex/float64/base/assert/is-equal(per chore: add missing bench task config tocomplex/float64/base/assert/is_equal#10235)benchmarktask configuration shape: samesrcandinclude, emptylibraries/libpath, and the package's own dependencies.float32variants (@stdlib/complex/float32/ctor,@stdlib/complex/float32/reim).Questions
No.
Other
The updated manifest was validated with
python3 -m json.tool.Checklist
AI Assistance
Yes
No
Code generation
Research and understanding
Disclosure
This PR was prepared with Qoder AI assistance under the contributor's direction. The change was reviewed and the manifest validated locally.
@stdlib-js/reviewers