Skip to content

fix: add missing bench task config to complex/float32/base/assert/is_equal - #16423

Open
harsh-thakkar7 wants to merge 1 commit into
stdlib-js:developfrom
harsh-thakkar7:fix/complex-float32-is-equal-bench-conf
Open

harsh-thakkar7 wants to merge 1 commit into
stdlib-js:developfrom
harsh-thakkar7:fix/complex-float32-is-equal-bench-conf

Conversation

@harsh-thakkar7

Copy link
Copy Markdown
Contributor

Resolves #11756.

Description

This pull request:

  • adds the missing benchmark task configuration to the manifest.json of @stdlib/complex/float32/base/assert/is-equal, mirroring the existing build and examples configurations.

Without it, C benchmark builds of dependent packages (e.g., blas/base/cgemv) fail to compile because no generated build emits is_equal.h for the benchmark task.

Related Issues

This pull request has the following related issues:

Reference Packages

This pull request followed these packages:

What carried over from the reference(s)?

  • The benchmark task configuration shape: same src and include, empty libraries/libpath, and the package's own dependencies.

What differed, or what did you have to work out yourself?

  • Only the dependency names, which are the float32 variants (@stdlib/complex/float32/ctor, @stdlib/complex/float32/reim).

Questions

No.

Other

The updated manifest was validated with python3 -m json.tool.

Checklist

AI Assistance

  • Yes

  • No

  • Code generation

  • Research and understanding

Disclosure

This PR was prepared with Qoder AI assistance under the contributor's direction. The change was reviewed and the manifest validated locally.


@stdlib-js/reviewers

@harsh-thakkar7
harsh-thakkar7 requested a review from a team November 1, 2026 05:18
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Nov 1, 2026
@stdlib-bot

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
complex/float32/base/assert/is-equal $\\color{green}100/100$
$\\color{green}+100.00\\%$
$\\color{green}4/4$
$\\color{green}+100.00\\%$
$\\color{green}1/1$
$\\color{green}+100.00\\%$
$\\color{green}100/100$
$\\color{green}+100.00\\%$

The above coverage report was generated for the changes in this PR.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs Review A pull request which needs code review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

@stdlib/complex/float32/base/assert/is-equal missing benchmark configuration in manifest.json

2 participants