Repository navigation
refactor: use constants/float64/nan in stats/base/dists/levy/mode - #16381
Merged
kgryte merged 1 commit intoOct 30, 2026
Merged
Conversation
hardikguptaofficialgit
requested review from
a team
and
a balanced review from Copilot
October 30, 2026 07:12
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request. Check if the Files changed in this pull request are included in default exclusions.
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
3 of 7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves None.
Description
This pull request:
stats/base/dists/levy/modewithSTDLIB_CONSTANT_FLOAT64_NAN@stdlib/constants/float64/nanto the build, benchmark, and examples manifest entriesRelated Issues
This pull request has the following related issues:
Reference Packages
This pull request followed these packages:
stats/base/dists/levy/median(refactor: useconstants/float64/naninstats/base/dists/levy/median#16372)is_nan.h, the macro swap, and the manifest dependency updatesis-nan, so the new dependency goes at the end there; the benchmark entry keepsepslastsrc/main.cis the only source changeQuestions
No.
Other
Built
src/main.cwithgcc -Wall -Wextraand no warnings.mode( 0.0, 1.0 )still gives ~0.333, andc <= 0or NaN inputs still give NaN.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
I used an AI assistant to make the edit following #16372, then checked the diff and compiled and ran the C implementation myself.
@stdlib-js/reviewers