Skip to content

build: unexport ESLINT_FLAGS to avoid collision with ESLint's feature-flag environment variable #16370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wanjinhao1 wants to merge 1 commit into
base: develop
Choose a base branch
from
+6 −0
Open

build: unexport ESLINT_FLAGS to avoid collision with ESLint's feature-flag environment variable #16370

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions tools/make/lib/lint/javascript/eslint.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,12 @@ eslint_flags := \
# Define user-supplied command-line options:
ESLINT_FLAGS ?=

# Ensure the `ESLINT_FLAGS` variable is not exported to the environment of invoked commands:
#
# - ESLint 9.39+ reads the `ESLINT_FLAGS` environment variable to enable feature flags (e.g., `unstable_native_nodejs_ts_config`) and throws `Unknown flag` for anything unrecognized.
# - GNU `make` exports command-line variables as environment variables to recipes, so `make ESLINT_FLAGS=--quiet` would otherwise cause `--quiet` to be interpreted as a feature flag instead of a command-line option.
unexport ESLINT_FLAGS

ifeq ($(AUTOFIX),true)
eslint_flags += --fix
endif
Expand Down
Loading