Skip to content

refactor: use constants/float64/nan in stats/base/dists/levy/mean - #16367

Merged
kgryte merged 1 commit into
stdlib-js:developfrom
hardikguptaofficialgit:refactor/levy-mean-nan-constant
Oct 30, 2026
Merged

kgryte merged 1 commit into
stdlib-js:developfrom
hardikguptaofficialgit:refactor/levy-mean-nan-constant

Conversation

@hardikguptaofficialgit

Copy link
Copy Markdown
Contributor

Resolves None.

Description

What is the purpose of this pull request?

This pull request:

  • replaces inline NaN generation in the C implementation of stats/base/dists/levy/mean with STDLIB_CONSTANT_FLOAT64_NAN
  • adds @stdlib/constants/float64/nan to the build, benchmark, and examples manifest entries

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Reference Packages

Did the content of this pull request follow one or more existing packages? Answering is optional.

This pull request followed these packages:

What carried over from the reference(s)?

  • include placement, macro usage, and manifest dependency updates

What differed, or what did you have to work out yourself?

  • checked the benchmark, example, and README C snippets; none had inline NaN, so only src/main.c changed

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

Built the C source and example locally with gcc -Wall -Wextra; NaN cases (c <= 0, NaN inputs) still return NaN and valid inputs return +Infinity.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution.

I used Cursor to apply the edit following #11768, then reviewed the diff and compiled and tested the C implementation myself.


@stdlib-js/reviewers

@hardikguptaofficialgit
hardikguptaofficialgit requested review from a team and a balanced review from Copilot October 29, 2026 22:50

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request. Check if the Files changed in this pull request are included in default exclusions.

@stdlib-bot stdlib-bot added the Statistics Issue or pull request related to statistical functionality. label Oct 29, 2026
@stdlib-bot

Copy link
Copy Markdown
Contributor

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

Getting Started

Next Steps

  1. A project maintainer will approve GitHub Actions workflows for your PR.
  2. All CI checks must pass before your submission can be fully reviewed.
  3. You'll need to address any failures in linting or unit tests.

Running Tests Locally

You can use make to run any of the CI commands locally from the root directory of the stdlib repository:

# Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"

# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"

If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR.

If you have any further questions while waiting for a response, please join our Zulip community to chat with project maintainers and other community members.

We appreciate your contribution!

Documentation Links

@stdlib-bot stdlib-bot added Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. and removed Needs Review A pull request which needs code review. labels Oct 29, 2026
@kgryte kgryte added difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. review: 5 and removed Needs Review A pull request which needs code review. labels Oct 30, 2026

@kgryte kgryte left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stdlib-bot

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/levy/mean $\\color{green}176/176$
$\\color{green}+100.00\\%$
$\\color{green}9/9$
$\\color{green}+100.00\\%$
$\\color{green}2/2$
$\\color{green}+100.00\\%$
$\\color{green}176/176$
$\\color{green}+100.00\\%$

The above coverage report was generated for the changes in this PR.

@kgryte
kgryte merged commit 50e0691 into stdlib-js:develop Oct 30, 2026
131 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue. review: 5 Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants