Repository navigation
feat: add math/base/special/boxcoxinvf - #16359
Open
Harsh28-raj wants to merge 1 commit into
Open
Harsh28-raj wants to merge 1 commit into
Harsh28-raj wants to merge 1 commit into
Conversation
Ref: stdlib-js#649 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request:
@stdlib/math/base/special/boxcoxinvf, a single-precision port of@stdlib/math/base/special/boxcoxinv, with JavaScript and C implementations.Related Issues
This pull request has the following related issues:
Reference Packages
This pull request followed these packages:
math/base/special/boxcoxinvmath/base/special/xlogyfboxcoxinv.xlogyf:f32rounding in JS,floattypes andf-suffixed literals in C,isnanf,STDLIB_CONSTANT_FLOAT32_NAN, theFF_FN-API macro,float32benchmark inputs, and reusing the double-precision Python fixtures withisAlmostSameValuef( out, f32( expected ), N ).math/base/special/boxcoxf#10150 (boxcoxf): single-precision dependencies throughout (expf,log1pf,isnanf) and "for a single-precision floating-point number" in descriptions.lambda*y, andlog1pf( lambda*y ) / lambdaare each rounded to single precision to mirror the C kernel.lambda = 0). Thelambda = 0case reduces toexpf( y )foryin[1, 10], so roundingyto single precision alone contributes up to roughlyyULPs relative to the double-precision reference.Questions
No.
Other
-std=c99 -Wall -Wextra -pedantic, no warnings) and checked it against the JavaScript implementation on all 9,270 fixture inputs plus edge cases: the results are bit-for-bit identical. The C example and C benchmark build and run. I could not build the Node.js addon locally (Windows, no MSVC), sotest.native.jsrelies on CI.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was written primarily by Claude Code, by porting
boxcoxinvand following the single-precision conventions inxlogyfand the review feedback on #10150. I reviewed the changes and ran the JavaScript tests and the C comparison locally.@stdlib-js/reviewers