Repository navigation
Conversation
Replace relative tolerance comparisons with ULP difference testing using `@stdlib/assert/is-almost-same-value`. The JS implementation reproduces the R reference fixtures bit-for-bit, so the minimum required ULP bound is `0` for all eight fixture loops. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Dj57ZWsJPp7hjbZT2Lv2Lr --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: skipped - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a part of #11352.
Description
This pull request:
stats/padjustfrom relative tolerance testing to ULP difference testing, using@stdlib/assert/is-almost-same-value.Each of the eight fixture loops previously computed a relative tolerance (
delta = abs( out[i] - expected[i] )compared againsttol = K * EPS * abs( expected[i] ), withKbeing10.0,15.0, or20.0) and asserted viat.ok. These are replaced withNotes:
0at all eight assertion sites. This is the measured minimum. ULP bounds were determined empirically by binary searching, for every individual comparison, the smallestmaxULPfor whichisAlmostSameValuereturnstrue, and then taking the per-site maximum over the full fixture set. All 38 comparisons across the eight R reference fixtures are exactly equal, so the required bound is0. Starting from a high bound and tightening converges to the same result.0is not brittle here:padjustperforms only basic IEEE-754 arithmetic together withmin/max/cumin/cumax, with no transcendental or libm-backed calls, so the computed values are bit-reproducible rather than platform-dependent.if ( out[ i ] === expected[ i ] )exact-comparison branch is folded into the single ULP assertion, sinceisAlmostSameValuealready returnstruefor exactly equal values. No fixture value is0, so no signed-zero edge case arises.@stdlib/constants/float64/epsand@stdlib/math/base/special/absrequires, and the now-unuseddeltaandtoldeclarations, are removed.test/test.native.js;test/test.jsis the only test file, and it is the only file changed.Verification:
make test TESTS_FILTER=".*/stats/padjust/.*"→ 75 passing, 0 failing, run twice to confirm determinism (no FMA/architecture-dependent variation).max-linesfinding.Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
No.
Other
The
editorconfiglint step could not be executed in the authoring environment, as it requires downloading theeditorconfig-checkerbinary from a GitHub repository which was out of scope for that environment (it fails identically on unmodified files). Compliance was instead verified manually: LF line endings, UTF-8, tab indentation, final newline present, and no trailing whitespace introduced.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code running as an unattended scheduled task. It studied the conventions established by already-converted packages, applied the conversion, determined the minimum ULP bounds empirically via the binary search described above, and verified the test suite and lint results.
@stdlib-js/reviewers
Generated by Claude Code