Skip to content

build: type check @stdlib/types declarations in CI - #16188

Open
0PrashantYadav0 wants to merge 4 commits into
stdlib-js:developfrom
0PrashantYadav0:ci/types-lib-check
Open

build: type check @stdlib/types declarations in CI#16188
0PrashantYadav0 wants to merge 4 commits into
stdlib-js:developfrom
0PrashantYadav0:ci/types-lib-check

Conversation

@0PrashantYadav0

@0PrashantYadav0 0PrashantYadav0 commented Oct 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Resolves None

Description

What is the purpose of this pull request?

This pull request:

  • adds a step to the lint_changed_files workflow that runs tsc on @stdlib/types (index.d.ts and test.ts) whenever either file changes, using the existing etc/typescript/tsconfig.json.
  • fixes @stdlib/types/test.ts so it passes that check: the BooleanArrayLike set method ignored its value argument (TS6133 under noUnusedLocals).

The workflow only runs ESLint on TypeScript declarations, and ESLint doesn't report compiler errors such as unresolved type names. That gap let @stdlib/types v0.5.0/v0.5.1 ship with Complex32, Complex32Array, and Float16Array used but never imported in the @stdlib/types/ndarray module (b9502d5; later fixed in b77ce8d). The test.ts lint step also only matches /docs/types/test.ts, so @stdlib/types/test.ts was never checked.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

  • Should this live in a make target instead of inline in the workflow? I kept it inline because nothing else in the repo runs tsc today.
  • Should it also run in lint_random_files?

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

Verified locally with the repo's pinned TypeScript (4.9.5):

  • current develop: passes.
  • index.d.ts from b77ce8d^ (the state published in 0.5.0/0.5.1): fails with
    • TS2552: Cannot find name 'Float16Array'
    • TS2552: Cannot find name 'Complex32Array'
    • TS2552: Cannot find name 'Complex32'
  • changes not touching @stdlib/types: step is skipped.

This doesn't fix #15916 by itself. That still needs a new @stdlib/types release from current develop.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

I used Claude Code to trace why CI missed the issue and to draft the workflow step; I reviewed and verified the changes locally.

@stdlib-js/reviewers

@0PrashantYadav0
test: fix unused parameter in @stdlib/types boolean array-like test
d10bb15 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown_pkg_readmes
    status: na
  - task: lint_markdown_docs
    status: na
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@0PrashantYadav0
build: type check @stdlib/types declarations in CI
0efb165 
The lint workflow only runs ESLint on TypeScript declarations, and
ESLint does not report TypeScript compiler errors. As a result,
`index.d.ts` shipped in `@stdlib/types` v0.5.0/v0.5.1 with unresolved
`Complex32`, `Complex32Array`, and `Float16Array` references.

Ref: stdlib-js#15916

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown_pkg_readmes
    status: na
  - task: lint_markdown_docs
    status: na
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@0PrashantYadav0
0PrashantYadav0 requested a review from a team October 16, 2026 05:43
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Oct 16, 2026
0PrashantYadav0
0PrashantYadav0 commented Oct 16, 2026
View reviewed changes
Comment thread .github/workflows/lint_changed_files.yml Outdated
Comment thread .github/workflows/lint_changed_files.yml Outdated
@0PrashantYadav0
docs: update comments for type declarations
508de13 
Signed-off-by: JoyBoy <devprashantkyadav@gmail.com>
@0PrashantYadav0
fix: add es6 to match the root
6972128 
Signed-off-by: JoyBoy <devprashantkyadav@gmail.com>
@0PrashantYadav0 0PrashantYadav0 added CI Issue or pull request specific to continuous integration environments. TypeScript Issue involves or relates to TypeScript. labels Oct 17, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CI Issue or pull request specific to continuous integration environments. Needs Review A pull request which needs code review. TypeScript Issue involves or relates to TypeScript.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Missing Complex32 import in @stdlib/types/ndarray causes TS2552 in v0.5.1

2 participants

@0PrashantYadav0 @stdlib-bot