Repository navigation
Conversation
Ref: #11352 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GZutuqEiUNY55tVUdfgbQk
|
Hello! 👋 We've noticed that you've been opening a number of PRs addressing good first issues. Thank you for your interest and enthusiasm! Now that you've made a few contributions, we suggest no longer working on good first issues. Instead, we encourage you to prioritize cleaning up any PRs which have yet to be merged and then proceed to work on more involved tasks. Not only does this ensure that other new contributors can work on things and get ramped up on all things stdlib, it also ensures that you can spend your time on more challenging problems. 🚀 For ideas for future PRs, feel free to search the codebase for TODOs and FIXMEs and be sure to check out other open issues on the issue tracker. Cheers! |
Coverage Report
The above coverage report was generated for the changes in this PR. |
Resolves a part of #11352.
Description
This pull request:
constants/float16/ln-two-pifrom relative tolerance assertions to ULP-based assertions, replacing thedelta/tolcomputation with@stdlib/number/float16/base/assert/is-almost-same-value.@stdlib/number/float64/base/to-float16before comparison, mirroring the already migratedconstants/float16/ln-halfandconstants/float16/pi-squaredpackages.0, which is the measured minimum.float64ToFloat16( lnf( 2.0*PI ) )and the exported constant are bit-for-bit identical (1.837890625), so no slack is required. The suite was run twice at0to confirm determinism.Only
test/test.jsis changed.Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
No.
Other
Verification performed locally:
make test TESTS_FILTER=".*/constants/float16/ln-two-pi/.*"→ 4 passing (run twice, identical results).make eslint-tests TESTS_FILTER=".*/constants/float16/ln-two-pi/.*"→ clean.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code, which studied the previously merged migrations in this family, applied the same idiom, and measured the minimum passing ULP bound.
@stdlib-js/reviewers
Generated by Claude Code