Skip to content

Fix eslint errors in float32/to-int32 and assert/is-accessor-property-in - #16183

Open
wanjinhao1 wants to merge 1 commit into
stdlib-js:developfrom
wanjinhao1:agent/fix-16182-lint-spacing
Open

wanjinhao1 wants to merge 1 commit into
stdlib-js:developfrom
wanjinhao1:agent/fix-16182-lint-spacing

Conversation

@wanjinhao1

@wanjinhao1 wanjinhao1 commented Oct 16, 2026 •

Copy link
Copy Markdown

Resolves #16182.

Description

What is the purpose of this pull request?

This pull request:

  • Fixes the 6 stdlib/jsdoc-example-require-spacing errors in @stdlib/number/float32/base/to-int32/lib/main.js by inserting an empty line between each require statement and the following code in the JSDoc @example blocks.
  • Fixes the 3 stdlib/eol-open-bracket-spacing errors in @stdlib/assert/is-accessor-property-in/examples/index.js by removing the space between the opening parenthesis and the leading object expression of the flagged calls.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

Verified by running the two custom rules (@stdlib/_tools/eslint/rules/jsdoc-example-require-spacing and @stdlib/_tools/eslint/rules/eol-open-bracket-spacing) via ESLint 9 against both the original and modified files: the original files reproduce all 9 errors reported by the lint workflow, and the modified files report 0 errors.

This pull request was prepared with AI assistance (Claude) and reviewed by the contributor.

@wanjinhao1
wanjinhao1 requested a review from a team October 16, 2026 01:31
@stdlib-bot

Copy link
Copy Markdown
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

@stdlib-bot stdlib-bot added Needs Review A pull request which needs code review. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue. labels Oct 16, 2026
@stdlib-bot

Copy link
Copy Markdown
Contributor

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

Getting Started

Next Steps

  1. A project maintainer will approve GitHub Actions workflows for your PR.
  2. All CI checks must pass before your submission can be fully reviewed.
  3. You'll need to address any failures in linting or unit tests.

Running Tests Locally

You can use make to run any of the CI commands locally from the root directory of the stdlib repository:

# Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"

# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"

If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR.

If you have any further questions while waiting for a response, please join our Zulip community to chat with project maintainers and other community members.

We appreciate your contribution!

Documentation Links

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue. Needs Review A pull request which needs code review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix JavaScript lint errors

2 participants