Repository navigation
test: migrate constants/float16/pi-squared to ULP-based assertions - #16170
Merged
Merged
Conversation
Replace the relative tolerance assertion in the `export equals π²` test with a ULP difference assertion via `@stdlib/number/float16/base/assert/is-almost-same-value`. The measured minimum ULP bound is `0`, as the computed value and the exported constant are bit-identical in half-precision. Ref: #11352 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Mpjxv2Udzx2apcT86dshJY --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: skipped - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a part of #11352.
Description
This pull request:
constants/float16/pi-squaredfrom a relative tolerance assertion to a ULP difference assertion.The
export equals π²test previously computeddelta = absf( FLOAT16_PI_SQUARED - v )andtol = EPS * vand asserted witht.ok( delta <= tol, ... ). It now delegates to@stdlib/number/float16/base/assert/is-almost-same-value:Final ULP constant:
0.test/test.jsNotes on how the bound was measured:
ulpDifference( v, FLOAT16_PI_SQUARED )is exactly0: the computed valuefloat64ToFloat16( pow( PI, 2 ) )and the exported constant are both9.8671875, i.e., bit-identical in half-precision.0is therefore the measured minimum and no smaller bound exists.maxULP === 0short-circuits toisSameValue, so the final assertion is an exact (same-value) comparison. This matches the already-convertedconstants/float16/ln-ten, which likewise settled on0.constants/float16/*packages (ln-ten,half-ln-two).4assertions pass both times.test.native.js, so there is no JS/C divergence to account for.typeofand the exact9.8671875value check) are intentionally left unchanged, as exact comparisons remain correct there.Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
No.
Other
The structure of the change intentionally mirrors the already-merged
constants/float32/pi-squaredconversion (#16088), which has a near-identical test file in the single-precision family.The bound is reproducible across architectures: the comparison is between two compile-time-fixed half-precision values and is not subject to FMA-contraction differences.
Note that the local
makepre-commit EditorConfig check could not run in this environment (theeditorconfig-checkerbinary download is network-blocked), so the changed file was verified manually for tabs-only indentation, no trailing whitespace, LF endings, and a final newline. All other pre-commit checks (JavaScript test lint, license headers, filenames, commit message) ran and passed, as didmake testfor this package.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code. It studied the already-converted packages in the same families (notably
constants/float32/pi-squaredandconstants/float16/ln-ten) to match the established idiom, then measured the minimum ULP bound empirically and verified determinism as described above.@stdlib-js/reviewers
🤖 Generated with Claude Code
https://claude.ai/code/session_01Mpjxv2Udzx2apcT86dshJY
Generated by Claude Code