Repository navigation
test: migrate constants/float32/ln-sqrt-two-pi to ULP-based assertions - #16155
Merged
Merged
Conversation
Replace the relative tolerance assertion in the package's test suite with a ULP difference assertion using `@stdlib/number/float32/base/assert/is-almost-same-value`. The computed value is exactly equal to the exported constant, so the minimum required ULP bound is `0`. Ref: #11352 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GkXfXrD8gfxspXedgyNAXa --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: skipped - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a part of #11352.
Description
This pull request:
@stdlib/constants/float32/ln-sqrt-two-pifrom relative tolerance testing to ULP difference testing, per [RFC]: Migratemath/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352.absf/EPStolerance computation with an assertion using@stdlib/number/float32/base/assert/is-almost-same-value, matching the idiom used in the already migrated sibling packagesconstants/float32/ln-twoandconstants/float32/pi-squared.The single converted assertion is
Final ULP bound:
0. This is the measured minimum.lnf( sqrtf( FLOAT32_TWO_PI ) )returns0.9189385175704956, which is bit-for-bit equal to the exported constant, so the ULP difference is zero and no slack is required. Starting from a loose bound and tightening, every value down to0passes;0is the smallest permissible non-negative integer, so the bound cannot be tightened further. The suite was run twice at the final bound to confirm determinism.Only the test file is changed:
Verification:
make test TESTS_FILTER=".*/constants/float32/ln-sqrt-two-pi/.*"→ 4/4 passing (run twice, identical results).make eslint-tests TESTS_FILTER=".*/constants/float32/ln-sqrt-two-pi/.*"→ clean.Note:
lint-editorconfig-filescould not run in this environment, as theeditorconfig-checkerwrapper fetches its binary from GitHub releases at runtime and outbound access to that endpoint is blocked. The changed lines were checked by hand for tab indentation, LF endings, absence of trailing whitespace, and a final newline.Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code running as an unattended scheduled task. It selected the package, mirrored the migration idiom from previously merged conversions in the same family, determined the minimum ULP bound empirically, and ran the package tests and test linter locally.
@stdlib-js/reviewers
🤖 Generated with Claude Code
https://claude.ai/code/session_01GkXfXrD8gfxspXedgyNAXa
Generated by Claude Code