Skip to content

test: remove excess whitespace in descriptions - #16145

Merged
kgryte merged 1 commit into
developfrom
claude/trusting-cannon-1szq40
Oct 14, 2026
Merged

kgryte merged 1 commit into
developfrom
claude/trusting-cannon-1szq40

Conversation

@Planeshifter

Copy link
Copy Markdown
Member

Description

What is the purpose of this pull request?

This pull request:

  • propagates fixes merged to develop between 2026-10-13T13:00Z and 2026-10-14T13:00Z to sibling packages.
  • applies the double-space cleanup from ebec084 ("fix: clamp only the upper bound and clean-up") to the remaining tape descriptions that have a stray double space between words:
    • array/fixed-endian-factory (test/test.includes.js)
    • string/format (test/test.js)
    • string/base/format-interpolate (test/test.js)

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

Validation

  • Searched all test/*.js files under lib/node_modules/@stdlib for tape descriptions with consecutive internal spaces. There were three hits, and all three are fixed here.
  • Two validators checked each site independently, then a separate pass confirmed that the fix applies verbatim and matches the sibling test titles. None of the files is autogenerated.

Excluded

  • ebec084 (clipIndex → clipUpperIndex in ndarray/*last-index*): every sibling ndarray/*last-index* wrapper already uses the corrected logic.
  • 0e949be (`k`-tuples → Tuples in ndarray/dcartesian-power notes): ndarray/scartesian-power already uses the corrected wording. The strided dcartesian-power and gcartesian-power packages take an explicit k parameter, so the wording there is correct.
  • b3f179a (missing trailing newline in datasets/moby-dick/datapackage.json): this is a dataset-specific fix with no propagatable source pattern.
  • random/base/minstd-shuffle/test/test.factory.js:1010 (r`normalized` ): this is a stray-character typo, not the same shape as the source fix, so it is left for a separate change.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

This PR was written primarily by Claude Code as part of an automated fix-propagation routine.


🤖 Generated with Claude Code

https://claude.ai/code/session_01QpKhVP7qEZ3HHEdTbWc7yC


Generated by Claude Code

Propagates fix from ebec084 ("fix: clamp only the upper bound and clean-up") to sibling test files containing the same double space in `tape` descriptions.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QpKhVP7qEZ3HHEdTbWc7yC
@stdlib-bot

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
array/fixed-endian-factory $\\color{red}1184/1437$
$\\color{green}+82.39\\%$
$\\color{red}155/168$
$\\color{green}+92.26\\%$
$\\color{red}23/33$
$\\color{green}+69.70\\%$
$\\color{red}1184/1437$
$\\color{green}+82.39\\%$
string/base/format-interpolate $\\color{red}712/739$
$\\color{green}+96.35\\%$
$\\color{red}123/139$
$\\color{green}+88.49\\%$
$\\color{green}12/12$
$\\color{green}+100.00\\%$
$\\color{red}712/739$
$\\color{green}+96.35\\%$
string/format $\\color{green}149/149$
$\\color{green}+100.00\\%$
$\\color{green}9/9$
$\\color{green}+100.00\\%$
$\\color{green}2/2$
$\\color{green}+100.00\\%$
$\\color{green}149/149$
$\\color{green}+100.00\\%$

The above coverage report was generated for the changes in this PR.

Copy link
Copy Markdown
Member Author

Run affected tests failed on both the push run and the PR run because it hit the 30-minute timeout (##[error]The action 'Run JavaScript tests' has timed out after 30 minutes.). No test assertion failed. In the part of the log that was retrieved, there is no not ok. When the job was cut off, it was running stats/base/dists/studentized-range/quantile.

The cause is in .github/workflows/scripts/run_affected_tests/run, not in this diff. The script adds every package that require()s a changed package. This PR changes string/format/test/test.js, so the script queued the test suite of every string/format dependent, which covers most of the repo. Any PR that touches a file under string/format will hit the same timeout. The changes here are three test-title strings only.

Re-running would time out again in the same way, so I'm not re-running it, and I'm not widening this PR to change the workflow. One possible fix in the workflow, for a separate PR: only look up dependents for packages that have changed files outside test/, benchmark/, docs/ and examples/. A change to a package's tests cannot affect its dependents.

# Only consider packages with changes outside test/benchmark/docs/examples when computing dependents:
src_packages=$(echo "${changed}" | tr ' ' '\n' | grep -vE '/(test|benchmark|docs|examples)/' | sed -E 's/\/(benchmark|bin|data|docs|etc|examples|include|lib|scripts|src|test)(\/.*)?$//' | sort -u | sed -E 's/^lib\/node_modules\///')
for package in ${src_packages}; do
	...
done

Generated by Claude Code

@kgryte
kgryte marked this pull request as ready for review October 14, 2026 14:05
@kgryte
kgryte requested a review from a team October 14, 2026 14:05
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Oct 14, 2026
@kgryte

kgryte commented Oct 14, 2026

Copy link
Copy Markdown
Member

As the CI failure is not due to changes introduced in this PR, I'll go ahead and merge.

@kgryte kgryte changed the title fix: remove extra whitespace in array and string test descriptions test: remove excess whitespace in descriptions Oct 14, 2026
@kgryte
kgryte merged commit a73d38b into develop Oct 14, 2026
32 of 34 checks passed
@kgryte
kgryte deleted the claude/trusting-cannon-1szq40 branch October 14, 2026 14:06
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Oct 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants