Repository navigation
test: migrate stats/incr/nanrmse to ULP-based assertions - #16138
Merged
Merged
Conversation
Ref: #11352 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01H6cmvnBMEXmQiUxa1oiEHW
Contributor
|
Hello! Thank you for your contribution to stdlib. We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:
This acknowledgment confirms that you've read the guidelines, which include:
We can't review or accept contributions without this acknowledgment. Thank you for your understanding and cooperation. We look forward to reviewing your contribution! |
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
kgryte
approved these changes
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request:
@stdlib/stats/incr/nanrmsefrom EPS/tolerance-based assertions to ULP-based assertions using@stdlib/assert/is-almost-same-value.NaN-ignoring loop, and the no-argument "current value" test) were tightened from an initial 64 down to the measured minimum of0ULPs (results are exactly equal to the reference computation; the previous tolerance was1.0 * EPS * abs(expected)). The suite was run twice at the final values with identical, passing results.absandEPSrequires and thedelta/tolvariables.Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was written primarily by Claude Code as an automated routine.
@stdlib-js/reviewers
🤖 Generated with Claude Code
https://claude.ai/code/session_01H6cmvnBMEXmQiUxa1oiEHW
Generated by Claude Code