Repository navigation
test: migrate constants/float16/ln-ten to ULP-based assertions - #16130
Merged
Merged
Conversation
Replace the relative tolerance comparison in the `constants/float16/ln-ten` test suite with a ULP-based assertion using `@stdlib/number/float16/base/assert/is-almost-same-value`. The measured minimum ULP difference is zero, so the assertion uses `0` ULPs. Resolves a part of #11352 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TtYau9K417VTv6oYzKnGzv --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: skipped - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a part of #11352.
Description
This pull request:
@stdlib/constants/float16/ln-tenfrom relative tolerance testing to ULP difference testing.absf( v - FLOAT16_LN10 ) <= EPS * FLOAT16_LN10tolerance comparison withisAlmostSameValue( v, FLOAT16_LN10, 0 ), using@stdlib/number/float16/base/assert/is-almost-same-value(the half-precision assertion utility, matching the idiom already used by sibling packages such asconstants/float16/half-ln-two).lnf(10)value to half-precision via@stdlib/number/float64/base/to-float16before comparison, so that the ULP difference is measured in half-precision units.@stdlib/math/base/special/absfand@stdlib/constants/float16/epsrequires.Final ULP constant:
0. Starting from a high bound and tightening, the measured maximum ULP difference betweenfloat64ToFloat16( lnf( 10.0 ) )and the exported constant is0(both are bit-identical half-precision values), so0is the minimum required ULP value. The package test suite was run repeatedly at the final bound (including via thepre-pushhook) and passed deterministically each time.Only
test/test.jsis modified; there is notest/test.native.jsfor this package.Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
No.
Other
Note that the
editorconfig-checkerpre-commit step could not run in the authoring environment because its binary is fetched from a GitHub release that was unreachable. The changed file was instead verified manually against.editorconfig(LF line endings, UTF-8, tab indentation, no trailing whitespace, final newline). JavaScript linting withetc/eslint/.eslintrc.tests.jsis clean.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was written primarily by Claude Code, which located the package, mirrored the conversion idiom from already-migrated sibling packages, measured the minimum ULP bound, and ran the tests and linters.
@stdlib-js/reviewers
🤖 Generated with Claude Code
https://claude.ai/code/session_01TtYau9K417VTv6oYzKnGzv
Generated by Claude Code