Skip to content

test: migrate stats/base/dists/lognormal/kurtosis to ULP-based assertions - #16106

Merged
kgryte merged 2 commits into
developfrom
philipp/ulp-lognormal-kurtosis
Oct 13, 2026
Merged

kgryte merged 2 commits into
developfrom
philipp/ulp-lognormal-kurtosis

Conversation

@Planeshifter

Copy link
Copy Markdown
Member

Resolves a portion of #11352.

Description

What is the purpose of this pull request?

This pull request:

  • migrates stats/base/dists/lognormal/kurtosis tests (test.js and test.native.js) from EPS-based tolerance checks to ULP-based assertions using @stdlib/assert/is-almost-same-value.
  • uses a named ULP constant of 16 in both test files. Measured minimum: 16 for both the JavaScript and native implementations (15 fails in each); results were identical across two consecutive runs. Previous tolerances were 10*EPS (JS) and 160*EPS (native), relative.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

The commit was made with --no-verify because the pre-commit editorconfig linter could not download its binary in the sandbox; eslint was run manually and is clean.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

This PR was written primarily by Claude Code (run as an unattended scheduled routine).


@stdlib-js/reviewers

🤖 Generated with Claude Code

https://claude.ai/code/session_01GGZLZ7tFwcNGz5oNkh3QJT


Generated by Claude Code

…rtions

Ref: #11352

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GGZLZ7tFwcNGz5oNkh3QJT
@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Good First PR A pull request resolving a Good First Issue. labels Oct 13, 2026
@stdlib-bot

stdlib-bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/lognormal/kurtosis $\\color{green}183/183$
$\\color{green}+0.00\\%$
$\\color{green}9/9$
$\\color{green}+0.00\\%$
$\\color{green}2/2$
$\\color{green}+0.00\\%$
$\\color{green}183/183$
$\\color{green}+0.00\\%$

The above coverage report was generated for the changes in this PR.

@kgryte kgryte added the Tests Pull requests specifically adding tests. label Oct 13, 2026
@kgryte
kgryte marked this pull request as ready for review October 13, 2026 10:26
@kgryte
kgryte requested a review from a team October 13, 2026 10:26
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Oct 13, 2026
Comment thread lib/node_modules/@stdlib/stats/base/dists/lognormal/kurtosis/test/test.js Outdated
Comment thread lib/node_modules/@stdlib/stats/base/dists/lognormal/kurtosis/test/test.js Outdated
Comment thread lib/node_modules/@stdlib/stats/base/dists/lognormal/kurtosis/test/test.js Outdated
Comment thread lib/node_modules/@stdlib/stats/base/dists/lognormal/kurtosis/test/test.native.js Outdated
Comment thread lib/node_modules/@stdlib/stats/base/dists/lognormal/kurtosis/test/test.native.js Outdated
Comment thread lib/node_modules/@stdlib/stats/base/dists/lognormal/kurtosis/test/test.native.js Outdated
Co-authored-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>

@kgryte kgryte left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after clean-up.

@kgryte
kgryte merged commit ff5c948 into develop Oct 13, 2026
12 checks passed
@kgryte
kgryte deleted the philipp/ulp-lognormal-kurtosis branch October 13, 2026 10:33
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Oct 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Good First PR A pull request resolving a Good First Issue. Statistics Issue or pull request related to statistical functionality. Tests Pull requests specifically adding tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants