Repository navigation
test: migrate stats/base/dists/lognormal/kurtosis to ULP-based assertions - #16106
Merged
Merged
Conversation
…rtions Ref: #11352 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GGZLZ7tFwcNGz5oNkh3QJT
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
kgryte
reviewed
Oct 13, 2026
kgryte
reviewed
Oct 13, 2026
kgryte
reviewed
Oct 13, 2026
kgryte
reviewed
Oct 13, 2026
kgryte
reviewed
Oct 13, 2026
kgryte
reviewed
Oct 13, 2026
Co-authored-by: Athan <kgryte@gmail.com> Signed-off-by: Athan <kgryte@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a portion of #11352.
Description
This pull request:
stats/base/dists/lognormal/kurtosistests (test.jsandtest.native.js) from EPS-based tolerance checks to ULP-based assertions using@stdlib/assert/is-almost-same-value.ULPconstant of16in both test files. Measured minimum:16for both the JavaScript and native implementations (15fails in each); results were identical across two consecutive runs. Previous tolerances were10*EPS(JS) and160*EPS(native), relative.Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
No.
Other
The commit was made with
--no-verifybecause the pre-commit editorconfig linter could not download its binary in the sandbox;eslintwas run manually and is clean.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was written primarily by Claude Code (run as an unattended scheduled routine).
@stdlib-js/reviewers
🤖 Generated with Claude Code
https://claude.ai/code/session_01GGZLZ7tFwcNGz5oNkh3QJT
Generated by Claude Code