Skip to content

test: migrate stats/base/dists/erlang/pdf to ULP-based assertions - #16092

Merged
kgryte merged 2 commits into
developfrom
philipp/ulp-erlang-pdf
Oct 13, 2026
Merged

kgryte merged 2 commits into
developfrom
philipp/ulp-erlang-pdf

Conversation

@Planeshifter

Copy link
Copy Markdown
Member

Ref: #11352

Description

What is the purpose of this pull request?

This pull request:

  • migrates test/test.native.js of @stdlib/stats/base/dists/erlang/pdf from computed EPS-based tolerances to ULP-based assertions using @stdlib/assert/is-almost-same-value, matching test/test.pdf.js and test/test.factory.js, which were already converted.
  • uses a named ULP variable per test, tightened to the measured minimum that passes over the full fixture set: 271 (large k and lambda), 154 (large k), and 146 (large lambda). These were identical across two runs.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

The native addon was built locally to run test.native.js; 3021 assertions pass and eslint is clean.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

This PR was written primarily by Claude Code.


@stdlib-js/reviewers

🤖 Generated with Claude Code

https://claude.ai/code/session_01LjXCCBpdm51wAD4HxwLMCy


Generated by Claude Code

@stdlib-bot stdlib-bot added the Statistics Issue or pull request related to statistical functionality. label Oct 12, 2026
@stdlib-bot

stdlib-bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/erlang/pdf $\\color{green}290/290$
$\\color{green}+0.00\\%$
$\\color{green}11/11$
$\\color{green}+0.00\\%$
$\\color{green}3/3$
$\\color{green}+0.00\\%$
$\\color{green}290/290$
$\\color{green}+0.00\\%$

The above coverage report was generated for the changes in this PR.

@kgryte kgryte added the Tests Pull requests specifically adding tests. label Oct 13, 2026
@kgryte
kgryte marked this pull request as ready for review October 13, 2026 10:36
@kgryte
kgryte requested a review from a team October 13, 2026 10:36
Signed-off-by: Athan <kgryte@gmail.com>

@kgryte kgryte left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after clean-up.

@kgryte
kgryte merged commit 622f433 into develop Oct 13, 2026
12 checks passed
@kgryte
kgryte deleted the philipp/ulp-erlang-pdf branch October 13, 2026 10:50
@stdlib-bot stdlib-bot added Needs Review A pull request which needs code review. and removed Needs Review A pull request which needs code review. labels Oct 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Statistics Issue or pull request related to statistical functionality. Tests Pull requests specifically adding tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants