Skip to content

test: migrate blas/ext/base/drrss to ULP-based assertions - #16087

Merged
kgryte merged 2 commits into
stdlib-js:developfrom
DivyanshuVortex:migrate-blas-ext-base-drrss-ulp
Oct 13, 2026
Merged

kgryte merged 2 commits into
stdlib-js:developfrom
DivyanshuVortex:migrate-blas-ext-base-drrss-ulp

Conversation

@DivyanshuVortex

Copy link
Copy Markdown
Contributor

Resolves a part of #11352.

Description

What is the purpose of this pull request?

This pull request:

These bounds were determined empirically using a script that calculated the maximum ULP difference across all test combinations.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

Test results via make test TESTS_FILTER=".*/blas/ext/base/drrss/.*" passed cleanly.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".


@stdlib-js/reviewers

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown_pkg_readmes
    status: na
  - task: lint_markdown_docs
    status: na
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@DivyanshuVortex
DivyanshuVortex requested a review from a team October 12, 2026 17:59
@stdlib-bot stdlib-bot added the Good First PR A pull request resolving a Good First Issue. label Oct 12, 2026
@stdlib-bot

stdlib-bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
blas/ext/base/drrss $\\color{red}448/450$
$\\color{green}+0.00\\%$
$\\color{red}33/34$
$\\color{green}+0.00\\%$
$\\color{green}4/4$
$\\color{green}+0.00\\%$
$\\color{red}448/450$
$\\color{green}+0.00\\%$

The above coverage report was generated for the changes in this PR.

@kgryte kgryte added difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. Tests Pull requests specifically adding tests. review: 5 labels Oct 12, 2026

z = drrss( x.length, x, 1, y, 1 );
isApprox( t, z, 2.82842712474619e+150, 1.0 );
isApprox( t, z, 2.82842712474619e+150, 0 );

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe these tests are broken. The third argument should be an array. Here, we are passing a number literal. This should be fixed here and in the other test files. It looks like we shouldn't need isApprox at all, as z is a scalar.

@kgryte kgryte left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left an initial comment.

@kgryte

kgryte commented Oct 12, 2026

Copy link
Copy Markdown
Member

We should also check whether other *rrss packages have similar mistakes.

@kgryte kgryte added Needs Changes Pull request which needs changes before being merged. review: 3 and removed review: 5 labels Oct 12, 2026
@stdlib-bot stdlib-bot added BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Needs Review A pull request which needs code review. labels Oct 12, 2026
… assertions)

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown_pkg_readmes
    status: na
  - task: lint_markdown_docs
    status: na
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@DivyanshuVortex
DivyanshuVortex force-pushed the migrate-blas-ext-base-drrss-ulp branch from 1cba8ae to 2e344aa Compare October 12, 2026 19:13
@kgryte kgryte removed Needs Review A pull request which needs code review. Needs Changes Pull request which needs changes before being merged. labels Oct 13, 2026
@kgryte
kgryte merged commit 3c34d8c into stdlib-js:develop Oct 13, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. Good First PR A pull request resolving a Good First Issue. review: 3 Tests Pull requests specifically adding tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants