Skip to content

test: migrate stats/incr/nanmmeanvar to ULP-based assertions - #16082

Merged
kgryte merged 1 commit into
developfrom
kgryte/ulp-nanmmeanvar
Oct 12, 2026
Merged

kgryte merged 1 commit into
developfrom
kgryte/ulp-nanmmeanvar

Conversation

@kgryte

@kgryte kgryte commented Oct 12, 2026

Copy link
Copy Markdown
Member

Resolves a part of #11352.

Description

What is the purpose of this pull request?

This pull request:

Implementation notes:

  • The package contained a single relative-tolerance assertion (in test/test.js, within the "if not provided an input value, the accumulator function returns the current accumulated values" test). The delta/tol computation was removed and replaced with t.strictEqual( isAlmostSameValue( actual[ 1 ], expected[ 1 ], 0 ), true, 'returns expected value' );.
  • Added the @stdlib/assert/is-almost-same-value require and removed the now unused @stdlib/math/base/special/abs and @stdlib/constants/float64/eps requires.
  • Final ULP constant: 0. Starting from an ULP bound of 64, the bound was tightened downward to the minimum passing integer. The accumulated unbiased sample variance for the test input ([ 2.0, NaN, 3.0, 10.0 ], window size 3) is bit-identical to the expected value 19.0, so no ULP slack is required. 0 is therefore both the measured minimum and the floor.
  • The test suite was run twice at the final bound (make test TESTS_FILTER=".*/stats/incr/nanmmeanvar/.*"), passing 282/282 assertions both times, confirming determinism.
  • This package has no test/test.native.js, so test/test.js is the only changed file.
  • This mirrors the idiom established for the sibling package in d9ecdf5 (test: migrate stats/incr/nanmmeanstdev to ULP-based assertions), which also settled on an ULP bound of 0.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

make eslint-tests TESTS_FILTER=".*/stats/incr/nanmmeanvar/.*" is clean. The project pre-commit and commit-msg hooks ran and passed; only the EditorConfig lint step was skipped, as this environment cannot download the editorconfig-checker binary. EditorConfig conformance (LF endings, tab indentation, final newline, no new trailing whitespace) was verified manually instead.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

This PR was authored by Claude Code, running as an unattended scheduled task. It studied #11352 and the diffs of previously converted packages to mirror the established idiom, applied the mechanical conversion, and then searched downward from an ULP bound of 64 to determine the minimum passing bound empirically.


🤖 Generated with Claude Code

https://claude.ai/code/session_014rFkWW1YS1fbtCqw2qnykJ


Generated by Claude Code

Ref: #11352

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_014rFkWW1YS1fbtCqw2qnykJ

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: skipped
  - task: lint_markdown_pkg_readmes
    status: na
  - task: lint_markdown_docs
    status: na
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Good First PR A pull request resolving a Good First Issue. labels Oct 12, 2026
@stdlib-bot

Copy link
Copy Markdown
Contributor

Hello! 👋

We've noticed that you've been opening a number of PRs addressing good first issues. Thank you for your interest and enthusiasm!

Now that you've made a few contributions, we suggest no longer working on good first issues. Instead, we encourage you to prioritize cleaning up any PRs which have yet to be merged and then proceed to work on more involved tasks.

Not only does this ensure that other new contributors can work on things and get ramped up on all things stdlib, it also ensures that you can spend your time on more challenging problems. 🚀

For ideas for future PRs, feel free to search the codebase for TODOs and FIXMEs and be sure to check out other open issues on the issue tracker. Cheers!

@stdlib-bot

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
stats/incr/nanmmeanvar $\\color{green}143/143$
$\\color{green}+100.00\\%$
$\\color{green}10/10$
$\\color{green}+100.00\\%$
$\\color{green}2/2$
$\\color{green}+100.00\\%$
$\\color{green}143/143$
$\\color{green}+100.00\\%$

The above coverage report was generated for the changes in this PR.

@kgryte kgryte added the Tests Pull requests specifically adding tests. label Oct 12, 2026
@kgryte
kgryte marked this pull request as ready for review October 12, 2026 13:40
@kgryte
kgryte requested a review from a team October 12, 2026 13:40
@kgryte
kgryte merged commit 6e2cfd7 into develop Oct 12, 2026
66 checks passed
@kgryte
kgryte deleted the kgryte/ulp-nanmmeanvar branch October 12, 2026 13:41
@stdlib-bot stdlib-bot added Needs Review A pull request which needs code review. and removed Needs Review A pull request which needs code review. labels Oct 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Good First PR A pull request resolving a Good First Issue. Statistics Issue or pull request related to statistical functionality. Tests Pull requests specifically adding tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants