Repository navigation
test: migrate stats/base/snanstdevch to ULP-based assertions - #16070
Closed
Planeshifter wants to merge 1 commit into
Closed
Planeshifter wants to merge 1 commit into
Planeshifter wants to merge 1 commit into
Conversation
Ref: #11352 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AtqS3EoAjWia2i1d1JYGDD
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
kgryte
requested changes
Oct 12, 2026
kgryte
left a comment
Member
There was a problem hiding this comment.
ULP values need to be inlined.
Contributor
|
Thank you for working on this pull request. However, we cannot accept your contribution as the issue this pull request seeks to resolve has already been addressed in a different pull request or commit. Thank you again for your interest in stdlib, and we look forward to reviewing your future contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #{{TODO: add issue number}}.
Description
This pull request:
stats/base/snanstdevch(test.ndarray.js,test.ndarray.native.js,test.snanstdevch.js,test.snanstdevch.native.js) from EPS-based tolerance checks to ULP-based assertions using@stdlib/number/float32/base/assert/is-almost-same-value.ULP = 1in each test file. This is the measured minimum:ULP = 0fails 2 assertions per file in both the JS and native tests, andULP = 1passes all 36 assertions per file. The result was identical across two runs.Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
No.
Other
Only test files are changed. The idiom mirrors the earlier
stats/base/snanstdevycmigration, except that the ULP value is a named constant instead of an inline literal.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was written primarily by Claude Code as an unattended scheduled task. The ULP bound was found by running the tests at decreasing values.
@stdlib-js/reviewers
🤖 Generated with Claude Code
https://claude.ai/code/session_01AtqS3EoAjWia2i1d1JYGDD
Generated by Claude Code