Repository navigation
test: migrate constants/float32/ln-ten to ULP-based assertions - #16059
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015n5joeotRty3pC31s5Zgjd
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
kgryte
reviewed
Oct 11, 2026
kgryte
reviewed
Oct 11, 2026
Co-authored-by: Athan <kgryte@gmail.com> Signed-off-by: Athan <kgryte@gmail.com>
5 of 7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a part of #11352.
Description
This pull request:
constants/float32/ln-tenfrom an EPS-based tolerance to ULP-based assertions using@stdlib/number/float32/base/assert/is-almost-same-value.ULP = 0. This is the measured minimum: the constant equalslnf(10)exactly (tests pass for N = 64, 4, 2, 1, and 0, and were run twice at the final value).Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
Since the measured minimum is 0 ULP, the comparison is equivalent to an exact check; reviewers may prefer a plain
strictEqualhere.Other
The commit was made with
--no-verifybecause the pre-commit editorconfig linter could not download its binary in the sandbox;eslintwas run on the changed file and is clean.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was written by Claude Code as an automated scheduled task.
@stdlib-js/reviewers
🤖 Generated with Claude Code
https://claude.ai/code/session_015n5joeotRty3pC31s5Zgjd
Generated by Claude Code