Repository navigation
feat: add C implementation for blas/ext/base/ndarray/cxmy - #16033
Open
AtharvaPatange wants to merge 7 commits into
Open
AtharvaPatange wants to merge 7 commits into
AtharvaPatange wants to merge 7 commits into
Conversation
stdlib-bot
added
BLAS
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
ujjwalv01
reviewed
Oct 10, 2026
ujjwalv01
reviewed
Oct 10, 2026
ujjwalv01
reviewed
Oct 10, 2026
ujjwalv01
reviewed
Oct 10, 2026
ujjwalv01
reviewed
Oct 10, 2026
ujjwalv01
reviewed
Oct 10, 2026
Member
|
Left a few suggestions. Mind making these changes? |
ujjwalv01
added
Needs Changes
Co-authored-by: Ujjwal Verma <ujjwalverma010305@gmail.com> Signed-off-by: Atharva Patange <164712914+AtharvaPatange@users.noreply.github.com>
Co-authored-by: Ujjwal Verma <ujjwalverma010305@gmail.com> Signed-off-by: Atharva Patange <164712914+AtharvaPatange@users.noreply.github.com>
…/example.c Co-authored-by: Ujjwal Verma <ujjwalverma010305@gmail.com> Signed-off-by: Atharva Patange <164712914+AtharvaPatange@users.noreply.github.com>
Co-authored-by: Ujjwal Verma <ujjwalverma010305@gmail.com> Signed-off-by: Atharva Patange <164712914+AtharvaPatange@users.noreply.github.com>
…c/benchmark.length.c Co-authored-by: Ujjwal Verma <ujjwalverma010305@gmail.com> Signed-off-by: Atharva Patange <164712914+AtharvaPatange@users.noreply.github.com>
Co-authored-by: Ujjwal Verma <ujjwalverma010305@gmail.com> Signed-off-by: Atharva Patange <164712914+AtharvaPatange@users.noreply.github.com>
Contributor
Author
Thanks for the detailed explanations! They helped me understand the reasoning behind the suggestions. I've made the changes accordingly. |
ujjwalv01
approved these changes
Oct 10, 2026
ujjwalv01
added
Needs Review
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #14819.
Description
What is the purpose of this pull request?
This pull request:
@stdlib/blas/ext/base/ndarray/cxmy.tryRequiredispatcher with a fallback to the JavaScript implementation when the native addon is unavailable.Related Issues
Does this pull request have any related issues?
This pull request has the following related issues:
Questions
Any questions for reviewers of this pull request?
No.
Other
Any other information relevant to this pull request?
No.
Checklist
Please ensure the following tasks are completed before submitting this pull request.
AI Assistance
When authoring the changes proposed in this PR, did you use any kind of AI assistance?
If you answered "yes" above, how did you use AI assistance?
Disclosure
AI assistance was used for reviewing changes and researching repository conventions.
I've checked each file and verified the result locally: the addon compiles without warnings, both the JavaScript and native test suites pass with the native results matching the JavaScript implementation, the C example and benchmarks run correctly, and ESLint reports no errors. Happy to make any adjustments.
@stdlib-js/reviewers