Repository navigation
test: migrate stats/incr/hmean to ULP-based assertions - #16024
Merged
Merged
Conversation
Replaces the relative tolerance assertion in the `stats/incr/hmean` accumulator test with an ULP difference assertion using `@stdlib/assert/is-almost-same-value`. The measured maximum ULP difference over the test data is 1, which is the minimum bound which passes (0 fails). Ref: #11352 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VAFLtSGuZB4wkzEqGU9r1n
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
kgryte
marked this pull request as ready for review
October 11, 2026 12:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a part of #11352.
Description
This pull request:
@stdlib/stats/incr/hmeanfrom relative tolerance testing to ULP difference testing.abs/@stdlib/constants/float64/epsrequires with@stdlib/assert/is-almost-same-value.delta/tolcomputation and theactual === expectedbranch in favor of a singlet.strictEqual( isAlmostSameValue( actual, expected, 1 ), true, 'returns expected value' );assertion.The package has a single test file (
test/test.js); there is notest/test.native.js.Measured ULP bound: the maximum ULP difference across the test data (
[ 2.0, 3.0, 2.0, 4.0, 3.0, 4.0 ]) is 1, arising from the final accumulated value (2.769230769230769vs.2.7692307692307696). All other iterations are bit-for-bit exact. Accordingly, the assertion uses a bound of1, which is the minimum passing value: re-running the suite with0fails one assertion, while1passes all 11 assertions. The suite was run twice at the final bound to confirm determinism.Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
No.
Other
make test TESTS_FILTER=".*/stats/incr/hmean/.*"(11/11).make lint-javascript-tests TESTS_FILTER=".*/stats/incr/hmean/.*".lib/node_modules/@stdlib/stats/incr/hmean/test/test.jsis modified.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code running as an unattended scheduled task. It studied the prior ULP migrations in the same package family (e.g.
stats/incr/nanhmean,stats/incr/mstdev) to mirror the established idiom, applied the test conversion, and determined the minimum passing ULP bound empirically by measuring per-iteration ULP differences and then verifying that0fails and1passes.@stdlib-js/reviewers
🤖 Generated with Claude Code
https://claude.ai/code/session_01VAFLtSGuZB4wkzEqGU9r1n
Generated by Claude Code