Repository navigation
test: migrate stats/base/dists/exponential/kurtosis to ULP-based assertions - #15952
Merged
kgryte merged 1 commit intoOct 12, 2026
Merged
Conversation
…sertions Ref: #11352 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G9Z13W95cxgpjVsDDGooyP
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
kgryte
approved these changes
Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: #11352
Description
This pull request:
test/test.native.jsofstats/base/dists/exponential/kurtosisaway from a computed tolerance (1.0 * EPS * abs( expected[i] )) and removes the now-unusedabs/EPSrequires anddelta/tolvariables.ULP bound
test.native.jsactually ran, 55/55 assertions) and passes at every bound down to 0; the native implementation matches the Julia fixtures exactly. Two consecutive runs gave identical results.isAlmostSameValuewould be redundant, so the loop now uses a plaint.strictEqual( y, expected[i], ... ), identical to the existingtest/test.js. No ULP constant was needed.Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
No.
Other
Only
test/test.native.jsis changed;test/test.jswas already exact.eslintis clean. The pre-commit hook could not run in this environment, so the commit used--no-verify.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was written by Claude Code running as an unattended scheduled task. It selected the package, mirrored the idiom from previously merged ULP migrations, measured the minimum bound, and verified tests and linting.
@stdlib-js/reviewers
🤖 Generated with Claude Code
https://claude.ai/code/session_01G9Z13W95cxgpjVsDDGooyP
Generated by Claude Code