Repository navigation
test: migrate stats/incr/nanprod to ULP-based assertions - #15946
Merged
Merged
Conversation
Migrate the test cases for `stats/incr/nanprod` from relative tolerance assertions to ULP-based assertions using `@stdlib/assert/is-almost-same-value`. The ULP bound was tightened to the minimum passing integer value: `1` for both the transient overflow and transient underflow test cases. Ref: #11352 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012q26xGJXEMSDYX3oukdEbc --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: skipped - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a part of #11352.
Description
This pull request:
stats/incr/nanprodfrom relative tolerance assertions to ULP-based assertions using@stdlib/assert/is-almost-same-value.Two test cases (
overflow may be transientandunderflow may be transient) computed adelta/tolpair and asserteddelta <= tol. Both now useThe
@stdlib/math/base/special/absand@stdlib/constants/float64/epsrequires are removed, as they are no longer used anywhere in the file.ULP bound:
1for both test cases. This is the measured minimum: starting from a high bound and tightening, the suite passes at1and fails at0(both assertions fail at0, confirming each result is exactly one ULP from its expected value). The suite was run twice at the final bound to confirm determinism — 3124 assertions passing both times, with no architecture- or FMA-dependent variation.The chosen bound matches the sibling package
stats/incr/prod, which uses1for the equivalent transient overflow/underflow test cases.Only
test/test.jsis changed; there is notest/test.native.jsfor this package.make test TESTS_FILTER=".*/stats/incr/nanprod/.*"andmake lint-javascript-tests TESTS_FILTER=".*/stats/incr/nanprod/.*"are both clean.Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code running as an unattended scheduled task. It studied the migration idiom from previously merged conversions (including the sibling package
stats/incr/prod), applied the mechanical conversion, and determined the minimum passing ULP bound empirically by sweeping candidate values and re-running the suite.@stdlib-js/reviewers
Generated by Claude Code