Skip to content

test: migrate stats/incr/nanprod to ULP-based assertions - #15946

Merged
kgryte merged 1 commit into
developfrom
kgryte/ulp-stats-incr-nanprod
Oct 12, 2026
Merged

kgryte merged 1 commit into
developfrom
kgryte/ulp-stats-incr-nanprod

Conversation

@kgryte

@kgryte kgryte commented Oct 7, 2026

Copy link
Copy Markdown
Member

Resolves a part of #11352.

Description

What is the purpose of this pull request?

This pull request:

Two test cases (overflow may be transient and underflow may be transient) computed a delta/tol pair and asserted delta <= tol. Both now use

t.strictEqual( isAlmostSameValue( acc(), expected, 1 ), true, 'returns expected value' );

The @stdlib/math/base/special/abs and @stdlib/constants/float64/eps requires are removed, as they are no longer used anywhere in the file.

ULP bound: 1 for both test cases. This is the measured minimum: starting from a high bound and tightening, the suite passes at 1 and fails at 0 (both assertions fail at 0, confirming each result is exactly one ULP from its expected value). The suite was run twice at the final bound to confirm determinism — 3124 assertions passing both times, with no architecture- or FMA-dependent variation.

The chosen bound matches the sibling package stats/incr/prod, which uses 1 for the equivalent transient overflow/underflow test cases.

Only test/test.js is changed; there is no test/test.native.js for this package. make test TESTS_FILTER=".*/stats/incr/nanprod/.*" and make lint-javascript-tests TESTS_FILTER=".*/stats/incr/nanprod/.*" are both clean.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

This PR was authored by Claude Code running as an unattended scheduled task. It studied the migration idiom from previously merged conversions (including the sibling package stats/incr/prod), applied the mechanical conversion, and determined the minimum passing ULP bound empirically by sweeping candidate values and re-running the suite.


@stdlib-js/reviewers


Generated by Claude Code

Migrate the test cases for `stats/incr/nanprod` from relative tolerance
assertions to ULP-based assertions using
`@stdlib/assert/is-almost-same-value`.

The ULP bound was tightened to the minimum passing integer value: `1`
for both the transient overflow and transient underflow test cases.

Ref: #11352

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012q26xGJXEMSDYX3oukdEbc

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: skipped
  - task: lint_markdown_pkg_readmes
    status: na
  - task: lint_markdown_docs
    status: na
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Good First PR A pull request resolving a Good First Issue. labels Oct 7, 2026
@stdlib-bot

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
stats/incr/nanprod $\\color{green}128/128$
$\\color{green}+100.00\\%$
$\\color{green}7/7$
$\\color{green}+100.00\\%$
$\\color{green}2/2$
$\\color{green}+100.00\\%$
$\\color{green}128/128$
$\\color{green}+100.00\\%$

The above coverage report was generated for the changes in this PR.

@kgryte kgryte added the Tests Pull requests specifically adding tests. label Oct 12, 2026
@kgryte
kgryte marked this pull request as ready for review October 12, 2026 00:21
@kgryte
kgryte requested a review from a team October 12, 2026 00:21
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Oct 12, 2026
@kgryte
kgryte merged commit 7ac0706 into develop Oct 12, 2026
82 checks passed
@kgryte
kgryte deleted the kgryte/ulp-stats-incr-nanprod branch October 12, 2026 00:22
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Oct 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Good First PR A pull request resolving a Good First Issue. Statistics Issue or pull request related to statistical functionality. Tests Pull requests specifically adding tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants