Repository navigation
test: migrate stats/base/dists/cauchy/quantile to ULP-based assertions - #15943
Merged
Merged
Conversation
Replaces the EPS-scaled relative tolerance checks in the fixture loops with `isAlmostSameValue` assertions. The maximum observed ULP difference against the Julia fixtures is 0 for all three fixture sets in each of `test.quantile.js`, `test.factory.js`, and `test.native.js`, so each assertion uses a bound of 0 ULP. Ref: #11352 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Cj2sbd8nh4w4WH3MnM6kHR --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: skipped - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
stdlib-bot
added
the
Statistics
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: #11352.
Description
This pull request:
stats/base/dists/cauchy/quantiletests (test.quantile.js,test.factory.js,test.native.js) from EPS-scaled relative tolerance checks to ULP-based assertions using@stdlib/assert/is-almost-same-value.large_gamma.json,positive_median.json, andnegative_median.json), the maximum ULP difference between the computed value and the Julia reference is 0 — i.e. the implementations reproduce the fixtures bit-for-bit — so the prior tolerances (50*EPS,125*EPS, and90*EPSrelative) were never exercised. Measured via@stdlib/number/float64/base/ulp-differenceand confirmed by running the suite twice at the final bound; results were identical across runs./* Higher tolerance than EPS because Julia gives slightly different results ... */comment blocks, which existed solely to justify the EPS-scaled tolerances being removed here. The measurements above show no remaining discrepancy against the Julia fixtures for these inputs.Only the three test files are touched. Bounds are written as inline integer literals, matching the merged conversions in the same family (e.g.
stats/base/dists/gumbel/quantile).Verification:
make test TESTS_FILTER=".*/stats/base/dists/cauchy/quantile/.*"→ 9051 assertions, 0 failing (run twice, identical).make lint-javascript-tests TESTS_FILTER=".*/stats/base/dists/cauchy/quantile/.*"→ clean.make install-node-addons NODE_ADDONS_PATTERN="stats/base/dists/cauchy/quantile") so thattest.native.jswas actually exercised rather than skipped.Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
test.native.js, happy to raise that one bound.Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code running as an unattended routine; it performed the conversion, measured the minimal ULP bounds, and ran the tests and linters.
@stdlib-js/reviewers
🤖 Generated with Claude Code
https://claude.ai/code/session_01Cj2sbd8nh4w4WH3MnM6kHR
Generated by Claude Code