Repository navigation
test: migrate stats/base/dists/frechet/cdf to ULP-based assertions - #15942
Open
Planeshifter wants to merge 1 commit into
Open
Planeshifter wants to merge 1 commit into
Planeshifter wants to merge 1 commit into
Conversation
Ref: #11352 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01S8HbpxnDU2cmZZk5k1VXv1
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
kgryte
requested changes
Oct 12, 2026
kgryte
left a comment
Member
There was a problem hiding this comment.
The ULP value needs to be inlined.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: #11352.
Description
This pull request:
stats/base/dists/frechet/cdftests (test.cdf.js,test.factory.js,test.native.js) from EPS-scaled tolerance checks to ULP-based assertions using@stdlib/assert/is-almost-same-value.ULPvariable in each fixture test, tightened to the measured minimum over the full fixture set: largealpha(large_shape): 1 ULP (was10*EPSrelative); larges(large_scale): 16 ULP (was10*EPSrelative); largealphaands(both_large): 5950 ULP (was4100*EPSrelative). Results were deterministic across repeated runs; the native addon test (built locally) passes at the same bounds.Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code (automated routine), which converted the tests and measured the minimal ULP bounds.
@stdlib-js/reviewers
🤖 Generated with Claude Code
https://claude.ai/code/session_01S8HbpxnDU2cmZZk5k1VXv1
Generated by Claude Code