Skip to content

test: fix test description in stats/base/dists/erlang/quantile - #15938

Closed
Planeshifter wants to merge 2 commits into
developfrom
philipp/fix-commit-review-2026-10-06
Closed

Planeshifter wants to merge 2 commits into
developfrom
philipp/fix-commit-review-2026-10-06

Conversation

@Planeshifter

Copy link
Copy Markdown
Member

Description

What is the purpose of this pull request?

This pull request:

  • Follow-up fixes for commits merged to develop between 2026-10-05T20:54:11Z and 2026-10-05T21:15:37Z (6f96b57e..dda96acc).
  • stats/base/dists/erlang/quantile
    • Fix ungrammatical tape description in test/test.factory.js (L124) introduced in dda96ac: change "if provided k is not a nonnegative integer, ..." to "if provided a k which is not a nonnegative integer, ...", matching test.native.js.

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

Validation

  • Reviewed 3 commits: 6f96b57 (negative-binomial/cdf), 53bcb81 (chi/quantile), dda96ac (erlang/quantile). Each adds a C implementation.
  • Checked style guide compliance against reference packages with native implementations: gamma/quantile, weibull/quantile, binomial/cdf, erlang/cdf, chi/cdf and poisson/cdf.
  • Ran a bug scan over the diffs. src/main.c matches lib/main.js semantics in all three packages, and the manifest dependencies cover every #include. A C spot check reproduced the documented example values.
  • Deliberately excluded anything requiring interpretation:
    • Missing * * * before the C section in the negative-binomial/cdf README. Many existing packages omit it too.
    • // FIXTURES // / // VARIABLES // ordering in test.native.js. Both orderings are common across dists/*.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

This PR was written primarily by Claude Code as part of an automated daily review of commits merged to develop.

🤖 Generated with Claude Code

https://claude.ai/code/session_016xMvqzd7nJSWhqSfAQH5wh


Generated by Claude Code

@stdlib-bot stdlib-bot added the Statistics Issue or pull request related to statistical functionality. label Oct 6, 2026
@stdlib-bot

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/erlang/quantile $\\color{green}283/283$
$\\color{green}+100.00\\%$
$\\color{green}11/11$
$\\color{green}+100.00\\%$
$\\color{green}3/3$
$\\color{green}+100.00\\%$
$\\color{green}283/283$
$\\color{green}+100.00\\%$

The above coverage report was generated for the changes in this PR.

@Planeshifter
Planeshifter marked this pull request as ready for review October 6, 2026 15:29
@Planeshifter
Planeshifter requested a review from a team October 6, 2026 15:29
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Oct 6, 2026
@kgryte kgryte added Tests Pull requests specifically adding tests. and removed Needs Review A pull request which needs code review. labels Oct 12, 2026
@kgryte kgryte added the autoclose: Already Resolved Pull request which should be auto-closed due proposed changes duplicating already included changes. label Oct 12, 2026
@stdlib-bot

Copy link
Copy Markdown
Contributor

Thank you for working on this pull request. However, we cannot accept your contribution as the issue this pull request seeks to resolve has already been addressed in a different pull request or commit.

Thank you again for your interest in stdlib, and we look forward to reviewing your future contributions.

@stdlib-bot stdlib-bot closed this Oct 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autoclose: Already Resolved Pull request which should be auto-closed due proposed changes duplicating already included changes. Statistics Issue or pull request related to statistical functionality. Tests Pull requests specifically adding tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants