Repository navigation
bench: clean-up - #15934
Merged
Merged
bench: clean-up#15934
Conversation
…special/hyp2f1` Moved the native C benchmark (includes the package header and calls `stdlib_base_hyp2f1`) from `benchmark/c/` to `benchmark/c/native/` (present in 97.1% of siblings) and updated its label to `c::native::` (95.2% of native C benchmarks). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PpipJ33aybJ58u4jotoxaB
…special/sqrtpif` Moved the native C benchmark (includes the package header and calls `stdlib_base_sqrtpif`) from `benchmark/c/` to `benchmark/c/native/` (present in 97.1% of siblings) and updated its label to `c::native::` (95.2% of native C benchmarks). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PpipJ33aybJ58u4jotoxaB
Added `#define NAME "tanh"` to both C benchmarks and printed it in place of the hardcoded `"tan"` label (NAME is defined and used in 99.7% of native and 99.4% of libm C benchmarks). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PpipJ33aybJ58u4jotoxaB
Added `@example` tags to the main function JSDoc in `lib/main.js`, mirroring the examples in `lib/index.js` (present in 99.7% of siblings). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PpipJ33aybJ58u4jotoxaB
Updated the `benchmark/c/native/benchmark.c` label from `c::` to `c::native::` (355 of 373 native C benchmarks, 95.2%). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PpipJ33aybJ58u4jotoxaB
Updated the `benchmark/c/native/benchmark.c` label from `c::` to `c::native::` (355 of 373 native C benchmarks, 95.2%). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PpipJ33aybJ58u4jotoxaB
Updated the `benchmark/c/native/benchmark.c` label from `c::` to `c::native::` (355 of 373 native C benchmarks, 95.2%). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PpipJ33aybJ58u4jotoxaB
Updated the `benchmark/c/native/benchmark.c` label from `c::` to `c::native::` (355 of 373 native C benchmarks, 95.2%). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PpipJ33aybJ58u4jotoxaB
Updated the `benchmark/c/native/benchmark.c` label from `c::` to `c::native::` (355 of 373 native C benchmarks, 95.2%). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PpipJ33aybJ58u4jotoxaB
Updated the `benchmark/c/native/benchmark.c` label from `c::` to `c::native::` (355 of 373 native C benchmarks, 95.2%). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PpipJ33aybJ58u4jotoxaB
Updated the `benchmark/c/native/benchmark.c` label from `c::` to `c::native::` (355 of 373 native C benchmarks, 95.2%). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PpipJ33aybJ58u4jotoxaB
Updated the `benchmark/c/native/benchmark.c` label from `c::` to `c::native::` (355 of 373 native C benchmarks, 95.2%). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PpipJ33aybJ58u4jotoxaB
Updated the `benchmark/c/native/benchmark.c` label from `c::` to `c::native::` (355 of 373 native C benchmarks, 95.2%). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PpipJ33aybJ58u4jotoxaB
Updated the `benchmark/c/native/benchmark.c` label from `c::` to `c::native::` (355 of 373 native C benchmarks, 95.2%). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PpipJ33aybJ58u4jotoxaB
Updated the `benchmark/c/native/benchmark.c` label from `c::` to `c::native::` (355 of 373 native C benchmarks, 95.2%). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PpipJ33aybJ58u4jotoxaB
Updated the `benchmark/c/native/benchmark.c` label from `c::` to `c::native::` (355 of 373 native C benchmarks, 95.2%). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PpipJ33aybJ58u4jotoxaB
Updated the `benchmark/c/native/benchmark.c` label from `c::` to `c::native::` (355 of 373 native C benchmarks, 95.2%). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PpipJ33aybJ58u4jotoxaB
Updated the `benchmark/c/native/benchmark.c` label from `c::` to `c::native::` (355 of 373 native C benchmarks, 95.2%). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PpipJ33aybJ58u4jotoxaB
Updated the `benchmark/c/native/benchmark.c` label from `c::` to `c::native::` (355 of 373 native C benchmarks, 95.2%). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PpipJ33aybJ58u4jotoxaB
Updated the `benchmark/c/native/benchmark.c` label from `c::` to `c::native::` (355 of 373 native C benchmarks, 95.2%). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PpipJ33aybJ58u4jotoxaB
Updated the `benchmark/c/native/benchmark.c` label from `c::` to `c::native::` (355 of 373 native C benchmarks, 95.2%). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PpipJ33aybJ58u4jotoxaB
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
Planeshifter
marked this pull request as ready for review
October 6, 2026 15:51
4 of 7 tasks
kgryte
approved these changes
Oct 12, 2026
math/base/special/{hyp2f1,sqrtpif,tanh,...}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request fixes misplaced and mislabeled C benchmarks in 20
math/base/specialpackages, so that they match the conventions used by nearly all of their 384 siblings.This pull request:
math/base/special/hyp2f1,math/base/special/sqrtpif: moves the native C benchmark frombenchmark/c/tobenchmark/c/native/, where 97.1% of siblings keep it, and relabels itc::native::(95.2% of native C benchmarks). Both files include the package header and callstdlib_base_*, so they are native benchmarks, and theirMakefileis byte-identical to sibling native Makefiles apart from the copyright year.math/base/special/tanh: both C benchmarks printed a hardcoded"tan"label, which was copied fromtan. This adds#define NAME "tanh"and printsNAMEinstead, as 99.7% of native and 99.4% of libm C benchmarks do. The libm benchmark keeps itsc::label.math/base/special/{beta,boxcox,cfloorf,dirac-delta,dirac-deltaf,kernel-cos,kernel-cosf,kernel-sin,kernel-sincos,kernel-sinf,kernel-tan,kernel-tanf,nonfibonacci,nonfibonaccif,sqrtpi,wrap,wrapf}: changes thebenchmark/c/native/benchmark.clabel fromc::toc::native::(355 of 373 native C benchmarks, 95.2%). Indirac-delta,dirac-deltaf,wrapandwrapf, the native and libm benchmarks currently print the same label, so their results cannot be told apart.Related Issues
None.
Questions
No.
Other
Namespace summary. All 384 members of
math/base/specialwere analyzed; none are autogenerated. A pattern counts as the majority only if at least 75% of members share it (288 packages). The following had a clear majority:package.jsonandmanifest.jsonkey sets;These were excluded because they gave no signal:
NaN;scriptsandstdlibkeys inpackage.json: empty everywhere.Validation. Structural features came from the filesystem. Semantic features came from static analysis of
lib/main.js. Every candidate was then reviewed independently for semantic intent, cross-references in tooling, tests and CI, and structural applicability.The C benchmark runners (
tools/make/lib/benchmark/c.mkandrun_affected_benchmarks) scan the wholebenchmark/ctree, so moving files under it does not affect benchmark discovery. Nothing parses the label strings. All 20 touched native benchmarks passgcc -fsyntax-only. Thetanhlibm benchmark compiles, runs and prints# c::tanh.Deliberately excluded:
fast,maxabsn,maxn,minabsn,minmaxabsn,minmaxn,minn,sici).fastis a sub-namespace, and the variadic functions have no C ABI.cfloor, which lacks a native C benchmark. Adding one needs new package-specific code.## Notessections.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was written primarily by Claude Code, as part of an automated run that compares packages across a namespace for inconsistencies.
@stdlib-js/reviewers
🤖 Generated with Claude Code
https://claude.ai/code/session_01PpipJ33aybJ58u4jotoxaB