Repository navigation
test: migrate simulate/iter/lanczos-pulse to ULP-based assertions - #15931
Merged
Merged
Conversation
Ref: #11352 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BU8YzjCHRg2W8cxoretxKJ
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a part of #11352.
Description
This pull request:
simulate/iter/lanczos-pulsefrom relative tolerance (EPS-scaled) comparisons to ULP-based assertions using@stdlib/assert/is-almost-same-value.if ( actual.value === expected[ i ].value ) { ... } else { delta/tol ... }block (9 occurrences intest/test.js) witht.strictEqual( isAlmostSameValue( actual.value, expected[ i ].value, 0 ), true, 'returns expected value' );.@stdlib/math/base/special/absand@stdlib/constants/float64/epsrequires, along with the associateddeltaandtoldeclarations.Final ULP constant:
0.The bound was tightened agentically: starting from
64, the ULP value was lowered until the minimum integer which still passes over the full fixture set was found. All generated waveform values match the expected values exactly, so0ULP is the measured minimum (the same bound the sibling packagesimulate/iter/periodic-sincsettled on in #15819). The suite was run twice at the final value to confirm determinism (3281 assertions passing on both runs, no FMA/arch-dependent variation).The package has no
test/test.native.js;test/test.validate.jscontains no tolerance comparisons and is therefore unchanged. Onlytest/test.jsis modified.Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
No.
Other
Verification performed locally:
make test TESTS_FILTER=".*/simulate/iter/lanczos-pulse/.*"→ 3281 passing, 0 failing.etc/eslint/.eslintrc.tests.js→ 0 errors, 0 warnings.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code running as an unattended scheduled task, following the migration recipe in #11352 and mirroring the idiom established by previously merged conversions in the same package family.
@stdlib-js/reviewers
Generated by Claude Code