Skip to content

test: fix typos in descriptions - #15912

Merged
kgryte merged 1 commit into
developfrom
claude/great-cerf-5yovaa
Oct 12, 2026
Merged

kgryte merged 1 commit into
developfrom
claude/great-cerf-5yovaa

Conversation

@Planeshifter

Copy link
Copy Markdown
Member

Description

What is the purpose of this pull request?

Follow-up fixes for commits merged to develop between 2026-10-04 23:15 -0500 (fc129b4) and 2026-10-05 00:55 -0500 (44c5b45).

This pull request:

  • stats/base/dists/gamma/quantile
    • Fixes two typos in tape test descriptions in test/test.native.js, introduced in 4f9e737: adds the missing space in "nonpositivebeta" and collapses the double space in "for a valid".

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

Validation

Scope: 7 commits adding C implementations for math/base/special/betaincinv and for stats/base/dists/ beta/median, gamma/quantile, betaprime/quantile, f/quantile, t/quantile, chisquare/quantile and chisquare/median.

  • Checked:
    • Style-guide compliance against reference native packages (*/mean, gamma/mode, betainc).
    • A bug scan of src/main.c, src/addon.c, lib/native.js, the manifests, headers, test.native.js, C examples and C benchmarks.
    • C vs JS logic parity, and the @example return values (recomputed).
  • Excluded (requires interpretation or is outside the window):
    • Duplicate assertions in the betaprime/F native tests.
    • Section ordering in the chisquare native tests.
    • A keyword change in chisquare/quantile/package.json.
    • The identical typos in the pre-existing test.quantile.js.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

This PR was written primarily by Claude Code as part of an automated daily review of commits merged to develop.


🤖 Generated with Claude Code

https://claude.ai/code/session_01Y7QY2WgoJcP5iTMLpj7mCU


Generated by Claude Code

@stdlib-bot stdlib-bot added the Statistics Issue or pull request related to statistical functionality. label Oct 5, 2026
@stdlib-bot

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/gamma/quantile $\\color{green}314/314$
$\\color{green}+100.00\\%$
$\\color{green}28/28$
$\\color{green}+100.00\\%$
$\\color{green}4/4$
$\\color{green}+100.00\\%$
$\\color{green}314/314$
$\\color{green}+100.00\\%$

The above coverage report was generated for the changes in this PR.

@Planeshifter
Planeshifter marked this pull request as ready for review October 5, 2026 18:26
@Planeshifter
Planeshifter requested review from a team and kgryte October 5, 2026 18:26
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Oct 5, 2026

@anandkaranubc anandkaranubc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to merge, @Planeshifter

@kgryte kgryte added Documentation Improvements, additions, or changes to documentation. and removed Needs Review A pull request which needs code review. labels Oct 12, 2026
@kgryte kgryte changed the title docs: fix typos in test descriptions in stats/base/dists/gamma/quantile test: fix typos in descriptions Oct 12, 2026
@kgryte
kgryte merged commit b44ccd7 into develop Oct 12, 2026
69 checks passed
@kgryte
kgryte deleted the claude/great-cerf-5yovaa branch October 12, 2026 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Documentation Improvements, additions, or changes to documentation. Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants