Repository navigation
test: migrate stats/base/dists/weibull/logpdf to ULP-based assertions - #15906
Merged
Merged
Conversation
Ref: #11352 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019dhnpndHupQsUA3fAyxi1g
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
kgryte
approved these changes
Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a part of #11352.
Description
This pull request:
stats/base/dists/weibull/logpdffrom computed relative-tolerance comparisons (delta = abs( y - expected[ i ] )/tol = N * EPS * abs( expected[ i ] ), asserted viat.ok( delta <= tol, ... )) to ULP-difference assertions using@stdlib/assert/is-almost-same-value.test/test.logpdf.js,test/test.factory.js, andtest/test.native.js(test/test.jshas no tolerance-based assertions).if ( y === expected[i] ) { ... } else { ... }branch in each fixture loop into a singlet.strictEqual( isAlmostSameValue( y, expected[ i ], N ), true, 'returns expected value' )assertion, matching the idiom used in the already-merged migrations (e.g.,stats/base/dists/gumbel/quantile).absandEPSrequires and thedelta/tolvariables (including a straytol = EPS;intest.factory.js).Only test files are changed.
ULP bounds
test/test.logpdf.jsboth_large1.0 * EPS * abs( expected )0test/test.logpdf.jslarge_scale1.0 * EPS * abs( expected )0test/test.logpdf.jslarge_shape1.0 * EPS * abs( expected )0test/test.factory.js1.0 * EPS * abs( expected )0test/test.native.jsboth_large/large_scale/large_shape2.0/2.0/10.0 * EPS * abs( expected )0Each bound is the minimum integer
Nfor which every fixture value passes. It was found by setting that one assertion toN(others at 64) and increasingNfrom 0 until the file passed. The minimum is0everywhere, so every fixture value is reproduced bit-for-bit. The suite was run twice at the final bounds with identical results (3023 passing assertions intest.logpdf.jsandtest.native.js, 3028 intest.factory.js, 0 failing), and the native addon was built sotest.native.jsactually ran.npx eslinton the test files is clean.Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
No.
Other
The ULP value is passed as a literal, as in the other merged migrations, rather than as a named constant. The
pre-commiteditorconfig step could not download its binary in this environment, so it was skipped; the diff only removes lines from tab-indented files.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was written primarily by Claude Code, running as an unattended scheduled task. It selected the package, studied previously migrated packages, performed the migration, and measured the minimum passing ULP bounds.
@stdlib-js/reviewers
🤖 Generated with Claude Code
https://claude.ai/code/session_019dhnpndHupQsUA3fAyxi1g
Generated by Claude Code