Repository navigation
test: migrate simulate/iter/bartlett-pulse to ULP-based assertions - #15903
Merged
Merged
Conversation
Replace the relative tolerance assertions in the `simulate/iter/bartlett-pulse` tests with ULP difference assertions using `@stdlib/assert/is-almost-same-value`. The returned waveform values agree exactly with the expected values, so the minimum required ULP bound is `0`. Ref: #11352 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KwLQg4yZrZHGzfeFS4zRSG
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
kgryte
marked this pull request as ready for review
October 12, 2026 12:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a part of #11352.
Description
This pull request:
simulate/iter/bartlett-pulsefrom relative tolerance testing to ULP difference testing, following the idiom established in [RFC]: Migratemath/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352.delta/tolcomparisons witht.strictEqual( isAlmostSameValue( actual.value, expected[ i ].value, 0 ), true, 'returns expected value' );, adds the@stdlib/assert/is-almost-same-valuerequire, and removes the now unused@stdlib/constants/float64/epsrequire. The@stdlib/math/base/special/absrequire is retained, asabsis still used by thebartletttest helper.Notes on the ULP bound:
0(used for all nine converted assertions).64and lowering to the minimum integer which still passes over the full set of generated expected values;0is the measured minimum, i.e., the generated waveform values agree with the expected values bit-for-bit.simulate/iter/bartlett-hann-pulse(test: migratesimulate/iter/bartlett-hann-pulseto ULP-based assertions #14614).Only the test file is changed; no implementation or fixture changes.
Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
No.
Other
Verification performed locally:
make test TESTS_FILTER=".*/simulate/iter/bartlett-pulse/.*"→ 3281 passing (run twice, identical results).make lint-javascript-tests TESTS_FILTER=".*/simulate/iter/bartlett-pulse/.*"→ clean.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code running as an unattended scheduled task. It studied the prior art in #11352 and the merged conversions for sibling packages, applied the mechanical conversion, and measured the minimum passing ULP bound empirically.
@stdlib-js/reviewers
Generated by Claude Code