Repository navigation
test: migrate stats/incr/mmeanvar to ULP-based assertions - #15856
Merged
Merged
Conversation
Ref: #11352 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JiDQWpZ5HtMarEZL1zWjrU --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: skipped - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
kgryte
marked this pull request as ready for review
October 12, 2026 13:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a part of #11352.
Description
This pull request:
stats/incr/mmeanvartests from relative tolerance (EPS) comparisons to ULP-based assertions using@stdlib/assert/is-almost-same-value.test/test.jswitht.strictEqual( isAlmostSameValue( actual[ 1 ], expected[ 1 ], 0 ), true, 'returns expected value' );and removes the now-unusedabsandEPSrequires, along with thedeltaandtollocals.ULP bound
The package has a single relative-tolerance assertion (the unbiased sample variance returned by the accumulator for the fixed input
[ 2.0, 3.0, 10.0 ]). The measured ULP difference between the computed and expected values is 0, so the final ULP constant is 0 (i.e., the computed value is exactly representable and bit-for-bit equal to the expected value). The previous tolerance (EPS * 19.0, roughly 1 ULP at that magnitude) was looser than required.The package test suite was run three times at the final ULP value to confirm determinism; all 424 assertions pass on each run. Only
test/test.jsis changed; the package has notest/test.native.js.Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
No.
Other
The repository's
make lint-editorconfig-filestarget could not be run in this environment, because theeditorconfig-checkerbinary is downloaded from a GitHub release that is unreachable from the sandbox. The changed file was checked manually for the relevant EditorConfig properties (LF line endings, tab indentation, no trailing whitespace, single trailing newline).make eslint-tests TESTS_FILTER=".*/stats/incr/mmeanvar/.*"passes.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code, running as an unattended task. The agent studied prior ULP migration commits in this repository, applied the migration to a single package, measured the minimum passing ULP value, and verified the package tests and test linting locally.
@stdlib-js/reviewers
🤖 Generated with Claude Code
https://claude.ai/code/session_01JiDQWpZ5HtMarEZL1zWjrU
Generated by Claude Code