Skip to content

test: migrate stats/incr/mmeanvar to ULP-based assertions - #15856

Merged
kgryte merged 1 commit into
developfrom
kgryte/ulp-stats-incr-mmeanvar
Oct 12, 2026
Merged

kgryte merged 1 commit into
developfrom
kgryte/ulp-stats-incr-mmeanvar

Conversation

@kgryte

@kgryte kgryte commented Oct 3, 2026

Copy link
Copy Markdown
Member

Resolves a part of #11352.

Description

What is the purpose of this pull request?

This pull request:

  • migrates stats/incr/mmeanvar tests from relative tolerance (EPS) comparisons to ULP-based assertions using @stdlib/assert/is-almost-same-value.
  • replaces the single computed-tolerance assertion in test/test.js with t.strictEqual( isAlmostSameValue( actual[ 1 ], expected[ 1 ], 0 ), true, 'returns expected value' ); and removes the now-unused abs and EPS requires, along with the delta and tol locals.

ULP bound

The package has a single relative-tolerance assertion (the unbiased sample variance returned by the accumulator for the fixed input [ 2.0, 3.0, 10.0 ]). The measured ULP difference between the computed and expected values is 0, so the final ULP constant is 0 (i.e., the computed value is exactly representable and bit-for-bit equal to the expected value). The previous tolerance (EPS * 19.0, roughly 1 ULP at that magnitude) was looser than required.

The package test suite was run three times at the final ULP value to confirm determinism; all 424 assertions pass on each run. Only test/test.js is changed; the package has no test/test.native.js.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

The repository's make lint-editorconfig-files target could not be run in this environment, because the editorconfig-checker binary is downloaded from a GitHub release that is unreachable from the sandbox. The changed file was checked manually for the relevant EditorConfig properties (LF line endings, tab indentation, no trailing whitespace, single trailing newline). make eslint-tests TESTS_FILTER=".*/stats/incr/mmeanvar/.*" passes.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

This PR was authored by Claude Code, running as an unattended task. The agent studied prior ULP migration commits in this repository, applied the migration to a single package, measured the minimum passing ULP value, and verified the package tests and test linting locally.


@stdlib-js/reviewers

🤖 Generated with Claude Code

https://claude.ai/code/session_01JiDQWpZ5HtMarEZL1zWjrU


Generated by Claude Code

Ref: #11352

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JiDQWpZ5HtMarEZL1zWjrU

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: skipped
  - task: lint_markdown_pkg_readmes
    status: na
  - task: lint_markdown_docs
    status: na
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Good First PR A pull request resolving a Good First Issue. labels Oct 3, 2026
@stdlib-bot

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
stats/incr/mmeanvar $\\color{green}324/324$
$\\color{green}+100.00\\%$
$\\color{green}38/38$
$\\color{green}+100.00\\%$
$\\color{green}2/2$
$\\color{green}+100.00\\%$
$\\color{green}324/324$
$\\color{green}+100.00\\%$

The above coverage report was generated for the changes in this PR.

@kgryte kgryte added the Tests Pull requests specifically adding tests. label Oct 12, 2026
@kgryte
kgryte marked this pull request as ready for review October 12, 2026 13:21
@kgryte
kgryte requested a review from a team October 12, 2026 13:21
@kgryte
kgryte merged commit dc667c9 into develop Oct 12, 2026
66 checks passed
@kgryte
kgryte deleted the kgryte/ulp-stats-incr-mmeanvar branch October 12, 2026 13:22
@stdlib-bot stdlib-bot added Needs Review A pull request which needs code review. and removed Needs Review A pull request which needs code review. labels Oct 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Good First PR A pull request resolving a Good First Issue. Statistics Issue or pull request related to statistical functionality. Tests Pull requests specifically adding tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants