Repository navigation
test: migrate constants/float64/ln-two-pi to ULP-based assertions - #15855
Merged
Merged
Conversation
Ref: #11352 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0157PdQFGkHiseLjJiHZNFNP
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
kgryte
reviewed
Oct 12, 2026
kgryte
reviewed
Oct 12, 2026
kgryte
reviewed
Oct 12, 2026
Co-authored-by: Athan <kgryte@gmail.com> Signed-off-by: Athan <kgryte@gmail.com>
5 of 7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a task from #11352.
Description
This pull request:
ln(2*pi)assertion inconstants/float64/ln-two-pifrom anEPS-based tolerance toisAlmostSameValuefrom@stdlib/assert/is-almost-same-value.ULPconstant of1, which is the measured minimum that passes (0 ULP fails, sinceln( 2.0*PI )differs from the constant by 1 ULP). The suite was run twice at this value with identical, passing results.Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
No.
Other
Only
test/test.jsis changed; ESLint passes.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was written primarily by Claude Code (scheduled routine).
@stdlib-js/reviewers
🤖 Generated with Claude Code
https://claude.ai/code/session_0157PdQFGkHiseLjJiHZNFNP
Generated by Claude Code