Repository navigation
test: migrate stats/base/dists/beta/pdf to ULP-based assertions - #15848
Merged
Merged
Conversation
Ref: #11352 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HhsK6pmAqQ5LtJMuHQMo7E --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: skipped - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
kgryte
marked this pull request as ready for review
October 12, 2026 13:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a part of #11352.
Description
This pull request:
stats/base/dists/beta/pdffrom relative tolerance assertions (delta <= tol, wheretol = N * EPS * abs( expected[ i ] )) to ULP-based assertions using@stdlib/assert/is-almost-same-value.test/test.pdf.js,test/test.factory.js, andtest/test.native.js. Only test files are changed; no implementation, fixture, or documentation changes are included.Each ULP bound is the measured minimum which passes over the full fixture set (1000 values per fixture). The minimum was determined by computing
ulpDifference( actual, expected )for every fixture value and taking the maximum; for each bound below,Npasses andN-1fails:test.pdf.jsboth_large.json180.0 * EPS245test.pdf.jslarge_alpha.json150.0 * EPS153test.pdf.jslarge_beta.json150.0 * EPS226test.factory.jsboth_large.json180.0 * EPS245test.factory.jslarge_alpha.json150.0 * EPS160test.factory.jslarge_beta.json150.0 * EPS226test.native.jsboth_large.json180.0 * EPS245test.native.jslarge_alpha.json150.0 * EPS153test.native.jslarge_beta.json150.0 * EPS226Notes:
large_alphabound is160intest.factory.jsversus153intest.pdf.js. The factory-created function and the main export evaluate the pdf in a different order for the same inputs, yielding a slightly different result forx = 0.5585154674819639,alpha = 15.443236158393903,beta = 9.67752027613441.make install-node-addons NODE_ADDONS_PATTERN="stats/base/dists/beta/pdf") and the C implementation reproduced the JavaScript results exactly, sotest.native.jsuses the same bounds astest.pdf.js.Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
No.
Other
make test TESTS_FILTER=".*/stats/base/dists/beta/pdf/.*"passes (run twice).make lint-javascript-tests TESTS_FILTER=".*/stats/base/dists/beta/pdf/.*"is clean.editorconfig-checkerbinary download was blocked by a network policy. The changed files were instead checked manually for LF line endings, tab indentation, no new trailing whitespace, and a final newline.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was written by Claude Code running as an unattended scheduled task. The test edits, the ULP minimization, and the verification runs described above were all performed by Claude Code; the migration idiom was mirrored from previously merged conversions in this family (e.g. #15656,
stats/base/dists/beta/logpdf).@stdlib-js/reviewers
🤖 Generated with Claude Code
https://claude.ai/code/session_01HhsK6pmAqQ5LtJMuHQMo7E
Generated by Claude Code