Repository navigation
test: migrate stats/bartlett-test to ULP-based assertions - #15835
Merged
Merged
Conversation
Ref: #11352 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QUpEV3abmFgv6PRGKLJYuJ
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
kgryte
marked this pull request as ready for review
October 12, 2026 13:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request:
stats/bartlett-testfrom EPS-scaled relative tolerance comparisons to ULP-based assertions, as described in [RFC]: Migratemath/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352.Specifically, in
test/test.js, the following idiomis replaced by
The
absandEPSrequires are dropped in favor of@stdlib/assert/is-almost-same-value.ULP bounds
The ULP constants were tightened to the measured minimum which still passes over the full fixture set (fixtures generated against R):
out.pValue9out.statistic4Each bound is minimal: lowering
pValueto8orstatisticto3causes the respective assertion to fail. The suite was run twice at the final bounds to confirm deterministic results.The package has no
test/test.native.js, so onlytest/test.jsrequired changes.Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
No.
Other
stats/levene-testandstats/fligner-test).Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was written primarily by Claude Code. The ULP bounds were determined empirically by measuring the actual ULP differences against the fixture values and then verifying that each bound is the minimum integer which still passes.
@stdlib-js/reviewers
Generated by Claude Code