Repository navigation
Conversation
Implement one complete JavaScript/C/native unblocked band LU routine with validated views, output-only stepwise pivots and reference-backed regression coverage. Assisted-by: OpenAI Codex agents
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add
@stdlib/lapack/base/dgbtf2with JavaScript, C and optional Node-API implementations of the unblocked LU factorization of a general band matrix. This is one complete routine under accepted RFC #2464 and the band-LU work tracked in #14631. Its proposed main8/ndarray11 interface supports full H×N compact band storage, independent signed strides and offsets, and output-only positive one-based stepwise row swaps. Repeated pivot targets are intentional, rather than a final permutation.The translation preserves pinned Reference-LAPACK elimination order, first absolute-maximum ties, singular continuation, and original fixed-alpha GER update order. It uses allocation-free private pivot/update helpers and unchanged DSCAL/DSWAP leaves. It preserves the reference's finite tiny-pivot reciprocal overflow behavior; INFO0 certifies neither stable arithmetic nor finite factors. The package retains the original BSD license and helper attribution.
Both public APIs validate intrinsic current ordinary typed-array views, full-view injectivity, capacities and conservative byte envelopes before writes. Resizable ordinary backing is supported under the documented stable synchronous lifetime precondition; shared backing is rejected. Native staging validates independently configured integer widths and physical pointer envelopes before allocating output pivot state or mutating inputs. Public native selection conservatively uses a signed32 domain and falls back before dispatch for wider valid metadata. Validated empty public calls return0 without accessing inactive arrays, dispatching or writing. The exact API remains a contribution proposal, not prior maintainer adoption.
Related issues
Validation
Checklist
AI Assistance
How AI assistance was used:
Disclosure
OpenAI Codex agents authored the implementation, reference harnesses, tests, benchmarks and documentation under benatsf's authorization. Separate Codex agents performed the independent automated review of the exact final source and actual execution evidence; the final reviewer was
/root/dgbtf2_review_resume. This is an AI-authored and AI-reviewed contribution. The guideline acknowledgment describes the agents' execution of those rules and does not claim benatsf personally authored, manually reviewed or understands the generated changes. Failed and superseded checks remain preserved, and prerequisite model checks are distinguished from actual package execution. Upstream CI and maintainer review are independent and are not claimed to have passed.