Repository navigation
test: migrate stats/base/dists/logistic/median to ULP-based assertions - #15825
Closed
Planeshifter wants to merge 2 commits into
Closed
Planeshifter wants to merge 2 commits into
Planeshifter wants to merge 2 commits into
Conversation
Ref: #11352 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01D5XYK6zMpPkYFZvhJtQJhc
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
Signed-off-by: Athan <kgryte@gmail.com>
Contributor
|
Thank you for working on this pull request. However, we cannot accept your contribution as the issue this pull request seeks to resolve has already been addressed in a different pull request or commit. Thank you again for your interest in stdlib, and we look forward to reviewing your future contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #{{TODO: add issue number}}.
Description
This pull request:
stats/base/dists/logistic/mediantests (test/test.js) from an EPS-based tolerance comparison toisAlmostSameValueULP-based assertions, using a single named constantMAX_ULP.MAX_ULPto the measured minimum: starting from 64, the full fixture set passes at 0 ULP (exact), so the constant is set to0. The suite was run repeatedly at the final value with identical, passing results.test/test.native.jsunchanged, as it already uses exact comparisons.Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was written primarily by Claude Code as an automated routine.
@stdlib-js/reviewers
🤖 Generated with Claude Code
https://claude.ai/code/session_01D5XYK6zMpPkYFZvhJtQJhc
Generated by Claude Code