feat: add C implementation for `blas/ext/base/ndarray/saxpby` by Erennn7 · Pull Request #15816 · stdlib-js/stdlib

Erennn7 · 2026-10-02T15:30:37Z

Progresses #14819

Description

What is the purpose of this pull request?

This pull request:

add C implementation for blas/ext/base/ndarray/saxpby

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

[RFC]: add C implementations for blas/ext/base/ndarray packages #14819

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

Read, understood, and followed the contributing guidelines.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

Yes
No

If you answered "yes" above, how did you use AI assistance?

Code generation (e.g., when writing an implementation or fixing a bug)
Test/benchmark generation
Documentation (including examples)
Research and understanding

Disclosure

AI assistance was used for reviewing changes and research. All files, builds, JS/native test suites, benchmarks, and linting have been verified locally.

@stdlib-js/reviewers

stdlib-bot · 2026-10-02T15:33:38Z

Coverage Report

Package	Statements	Branches	Functions	Lines
blas/ext/base/ndarray/saxpby	$\\color{green}231/231$ $\\color{green}+0.00\\%$	$\\color{green}7/7$ $\\color{green}+0.00\\%$	$\\color{green}2/2$ $\\color{green}+0.00\\%$	$\\color{green}231/231$ $\\color{green}+0.00\\%$

The above coverage report was generated for the changes in this PR.

ujjwalv01 · 2026-10-05T21:23:14Z

+int main( void ) {
+	// Create data buffers:
+	float dataX[] = { 1.0f, 2.0f, 3.0f, 4.0f };
+	float dataY[] = { 2.0f, 3.0f, 4.0f, 5.0f };


Suggested change

float dataY[] = { 2.0f, 3.0f, 4.0f, 5.0f };

const float dataX[] = { 1.0f, -2.0f, 3.0f, -4.0f, 5.0f, -6.0f, 7.0f, -8.0f };

float dataY[] = { 2.0f, 3.0f, 4.0f, 5.0f, 6.0f, 7.0f, 8.0f, 9.0f };

ujjwalv01 · 2026-10-05T21:23:19Z

+	const int64_t ndims = 1;
+
+	// Specify the array shape:
+	int64_t shape[] = { 4 };


Suggested change

int64_t shape[] = { 4 };

int64_t shape[] = { 8 };

ujjwalv01 · 2026-10-05T21:23:30Z

+	stdlib_blas_ext_saxpby( arrays );
+
+	// Print the result:
+	for ( int i = 0; i < 4; i++ ) {


Suggested change

for ( int i = 0; i < 4; i++ ) {

for ( int i = 0; i < 8; i++ ) {

ujjwalv01 · 2026-10-05T21:23:38Z

+int main( void ) {
+    // Create data buffers:
+    float dataX[] = { 1.0f, 2.0f, 3.0f, 4.0f };
+    float dataY[] = { 2.0f, 3.0f, 4.0f, 5.0f };


Suggested change

float dataY[] = { 2.0f, 3.0f, 4.0f, 5.0f };

const float dataX[] = { 1.0f, -2.0f, 3.0f, -4.0f, 5.0f, -6.0f, 7.0f, -8.0f };

float dataY[] = { 2.0f, 3.0f, 4.0f, 5.0f, 6.0f, 7.0f, 8.0f, 9.0f };

The C example here repeats the same data and constants as the usage example above, so the two end up showing the exact same computation. It would be clearer if this one used a different setup.

How about reusing the data from blas/ext/base/ndarray/dxpy's C example? Since y is also an input for saxpby, it should stay non-zero;

ujjwalv01 · 2026-10-05T21:23:40Z

+    const int64_t ndims = 1;
+
+    // Specify the array shape:
+    int64_t shape[] = { 4 };


Suggested change

int64_t shape[] = { 4 };

int64_t shape[] = { 8 };

ujjwalv01 · 2026-10-05T21:23:43Z

+    const int64_t nsubmodes = 1;
+
+    // Create input ndarrays:
+    struct ndarray *x = stdlib_ndarray_allocate( STDLIB_NDARRAY_FLOAT32, (uint8_t *)dataX, ndims, shape, strides, offset, order, imode, nsubmodes, submodes );


Suggested change

struct ndarray *x = stdlib_ndarray_allocate( STDLIB_NDARRAY_FLOAT32, (uint8_t *)dataX, ndims, shape, strides, offset, order, imode, nsubmodes, submodes );

struct ndarray *x = stdlib_ndarray_allocate( STDLIB_NDARRAY_FLOAT32, (uint8_t *)dataX, ndims, shape, strides, offset, order, imode, nsubmodes, submodes );

ujjwalv01 · 2026-10-05T21:23:47Z

+    stdlib_blas_ext_saxpby( arrays );
+
+    // Print the result:
+    for ( int i = 0; i < 4; i++ ) {


Suggested change

for ( int i = 0; i < 4; i++ ) {

for ( int i = 0; i < 8; i++ ) {

ujjwalv01 · 2026-10-05T21:29:29Z

Left a few suggestions;

Erennn7 · 2026-10-06T16:14:32Z

Thanks for the review @ujjwalv01! I've updated binding.gyp and updated the C example data and formatting accordingly.

ujjwalv01

Looks good to me!

0PrashantYadav0

The AI disclosure in the PR description still reads {{TODO: add disclosure if applicable}} even though "Yes" is checked. Please fill it in.

Co-authored-by: JoyBoy <prashantyadav09783@gmail.com> Signed-off-by: Samarth Kolarkar <144821218+Erennn7@users.noreply.github.com>

feat: add C implementation for blas/ext/base/ndarray/saxpby

9db3355

Erennn7 requested a review from a team October 2, 2026 15:30

stdlib-bot added BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Needs Review A pull request which needs code review. labels Oct 2, 2026

ujjwalv01 reviewed Oct 5, 2026

View reviewed changes

ujjwalv01 added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Oct 5, 2026

fix: update binding.gyp and C example in blas/ext/base/ndarray/saxpby

337f203

ujjwalv01 approved these changes Oct 6, 2026

View reviewed changes

ujjwalv01 added Feature Issue or pull request for adding a new feature. Needs Review A pull request which needs code review. C Issue involves or relates to C. and removed Needs Changes Pull request which needs changes before being merged. labels Oct 6, 2026

fix: update binding.gyp in blas/ext/base/ndarray/saxpby

3921cc5

0PrashantYadav0 reviewed Oct 9, 2026

View reviewed changes

Comment thread lib/node_modules/@stdlib/blas/ext/base/ndarray/saxpby/README.md Outdated

Update lib/node_modules/@stdlib/blas/ext/base/ndarray/saxpby/README.md

4cd42f3

Co-authored-by: JoyBoy <prashantyadav09783@gmail.com> Signed-off-by: Samarth Kolarkar <144821218+Erennn7@users.noreply.github.com>

0PrashantYadav0 approved these changes Oct 10, 2026

View reviewed changes

Navigation Menu

Repository navigation

feat: add C implementation for `blas/ext/base/ndarray/saxpby` - #15816

feat: add C implementation for `blas/ext/base/ndarray/saxpby`#15816
Erennn7 wants to merge 4 commits into
stdlib-js:developfrom
Erennn7:c-impl/blas/ext/base/ndarray/saxpby

Erennn7 commented Oct 2, 2026 •

edited

Loading

Uh oh!

stdlib-bot commented Oct 2, 2026 •

edited

Loading

Uh oh!

ujjwalv01 Oct 5, 2026

Uh oh!

ujjwalv01 Oct 5, 2026

Uh oh!

ujjwalv01 Oct 5, 2026

Uh oh!

ujjwalv01 Oct 5, 2026

Uh oh!

ujjwalv01 Oct 5, 2026

Uh oh!

ujjwalv01 Oct 5, 2026

Uh oh!

ujjwalv01 Oct 5, 2026

Uh oh!

ujjwalv01 commented Oct 5, 2026

Uh oh!

Erennn7 commented Oct 6, 2026

Uh oh!

ujjwalv01 left a comment

Uh oh!

0PrashantYadav0 left a comment

Uh oh!

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	float dataY[] = { 2.0f, 3.0f, 4.0f, 5.0f };
	const float dataX[] = { 1.0f, -2.0f, 3.0f, -4.0f, 5.0f, -6.0f, 7.0f, -8.0f };
	float dataY[] = { 2.0f, 3.0f, 4.0f, 5.0f, 6.0f, 7.0f, 8.0f, 9.0f };

	for ( int i = 0; i < 4; i++ ) {
	for ( int i = 0; i < 8; i++ ) {

	struct ndarray x = stdlib_ndarray_allocate( STDLIB_NDARRAY_FLOAT32, (uint8_t )dataX, ndims, shape, strides, offset, order, imode, nsubmodes, submodes );
	struct ndarray x = stdlib_ndarray_allocate( STDLIB_NDARRAY_FLOAT32, (uint8_t )dataX, ndims, shape, strides, offset, order, imode, nsubmodes, submodes );

Conversation

Erennn7 commented Oct 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issues

Questions

Other

Checklist

AI Assistance

Disclosure

Uh oh!

stdlib-bot commented Oct 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report

Uh oh!

ujjwalv01 Oct 5, 2026

Choose a reason for hiding this comment

Uh oh!

ujjwalv01 Oct 5, 2026

Choose a reason for hiding this comment

Uh oh!

ujjwalv01 Oct 5, 2026

Choose a reason for hiding this comment

Uh oh!

ujjwalv01 Oct 5, 2026

Choose a reason for hiding this comment

Uh oh!

ujjwalv01 Oct 5, 2026

Choose a reason for hiding this comment

Uh oh!

ujjwalv01 Oct 5, 2026

Choose a reason for hiding this comment

Uh oh!

ujjwalv01 Oct 5, 2026

Choose a reason for hiding this comment

Uh oh!

ujjwalv01 commented Oct 5, 2026

Uh oh!

Erennn7 commented Oct 6, 2026

Uh oh!

ujjwalv01 left a comment

Choose a reason for hiding this comment

Uh oh!

0PrashantYadav0 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Erennn7 commented Oct 2, 2026 •

edited

Loading

stdlib-bot commented Oct 2, 2026 •

edited

Loading