Repository navigation
Conversation
`ln( 1 - (b-x)^2/((b-a)(b-c)) )` loses the digits of a result close to `0` and returns `0` once the fraction is below `2^-53`. The fixtures are now generated from the textbook formula in extended precision.
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request:
log1p( -(b-x)^2 / ((b-a)(b-c)) )instead ofln( 1 - (b-x)^2 / ((b-a)(b-c)) )forc < x < binstats/base/dists/triangular/logcdf(JS, factory and C).Close to
b, the CDF is close to1and the log-CDF is close to0. Forming1 - (b-x)^2/...before takinglnloses those digits, and once the fraction is below2^-53the result is0:Fixtures and tests:
runner.jlnow evaluates the textbook piecewise formula in 2048-bitBigFloatinstead ofDistributions.logcdf, which has the samelog(1 - ...).Distributionsis dropped fromREQUIRE, and the three fixtures are regenerated with the same input ranges.near_b.jsonwithb - xlog-spaced from1e-8to0.1timesb - c.near_b.develop, 1,007 of the 4,012 assertions intest.logcdf.jsfail. With this change they all pass.Related Issues
None.
Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was written primarily by Claude Code. I found the bug by scanning
stats/base/distsforln( 1.0 - ... ).@stdlib-js/reviewers