Repository navigation
test: migrate blas/base/cscal to ULP-based assertions - #15733
Open
Planeshifter wants to merge 2 commits into
Open
Planeshifter wants to merge 2 commits into
Planeshifter wants to merge 2 commits into
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01H7UKv9v5sNgHJ4XaHfMfCh
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
kgryte
requested changes
Oct 1, 2026
kgryte
left a comment
Member
There was a problem hiding this comment.
ULP values need to be inlined in both files.
Member
Author
|
An automated check found potentially unrelated issue/PR references in this PR:
Why this matters: GitHub automatically closes issues referenced with What to do:
This assessment was generated by an AI model and is informational only. Generated by Claude Code |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #11352.
Description
This pull request:
blas/base/cscaltests (test.cscal.jsandtest.ndarray.js) from EPS-based tolerance checks to ULP-based assertions using@stdlib/number/float32/base/assert/is-almost-same-value.ULP = 5in each file. The measured minimum over the full fixture set is 5 (4 fails intest.ndarray.js; 5 passes). Results were identical across two runs.test.cscal.native.jsandtest.ndarray.native.jsunchanged, as the native addon could not be built in the environment used to author this PR, so a native ULP bound could not be measured.Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
No.
Other
The commit was created with
--no-verifybecause the pre-commit editorconfig linter binary could not be downloaded in the sandbox. ESLint passes on the changed files.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was written primarily by Claude Code as an automated scheduled run.
@stdlib-js/reviewers
🤖 Generated with Claude Code
https://claude.ai/code/session_01H7UKv9v5sNgHJ4XaHfMfCh
Generated by Claude Code