Repository navigation
Conversation
BREAKING CHANGE: use single-element arrays for `scale` and `sumsq` To migrate, users should provide `scale` and `sumsq` as single-element `Float64Array`s containing the input values. The routine overwrites them with the updated scaling factor and sum of squares and no longer returns an output array. For the `ndarray` method, replace `scale, sumsq, out, strideOut, offsetOut` with `scale, offsetScale, sumsq, offsetSumsq`.
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
Member
Author
|
Note Follow-up once this PR is merged (self-reminder) - the following open PRs call
Nothing merged on |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves none.
Description
This pull request:
lapack/base/dlassqto write its scalar outputs to separate single-element arrays rather than a packed two-elementoutarray, following the convention used bylapack/base/dladivandlapack/base/dlaln2(feat: addlapack/base/dlaln2#15222).dlassq( N, X, strideX, scale, sumsq )anddlassq.ndarray( N, X, strideX, offsetX, scale, offsetScale, sumsq, offsetSumsq ), wherescaleandsumsqareFloat64Arrays containing a single element. Each array provides the input value and is overwritten with the updated value, mirroring theINOUTsemantics of the reference Fortran routine.void), as the routine has no matrix output.lapack/basenamespace declarations accordingly.The underlying algorithm is unchanged. All previously expected values are retained in the tests, and the refactored implementation was verified to be bit-for-bit identical to the previous implementation across 200,000 randomly generated inputs spanning the small, medium, and large scaling regimes,
NaN,±Infinity, andN <= 0.Related Issues
This pull request has the following related issues:
No.
Questions
No.
Other
This is a breaking change to the public API. Nothing merged on
developcurrently callsdlassq; the open PRs which do are listed in a follow-up comment below and will be updated once this lands.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
{{TODO: add disclosure if applicable}}
@stdlib-js/reviewers